From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id A9E9938618AA
 for <gdb-patches@sourceware.org>; Wed, 16 Sep 2020 20:44:24 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A9E9938618AA
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net
 [192.222.181.218])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 0CF7B1E96F;
 Wed, 16 Sep 2020 16:44:23 -0400 (EDT)
Subject: Re: [pushed] gdb: remove TYPE_INSTANCE_FLAGS
To: Pedro Alves <pedro@palves.net>, Luis Machado <luis.machado@linaro.org>,
 gdb-patches@sourceware.org
References: <20200914213112.19593-1-pedro@palves.net>
 <20200914213112.19593-2-pedro@palves.net>
 <c88b11ac-db17-7a92-37b3-076dc7949be1@simark.ca>
 <3db19da5-af04-2f7f-52ed-c496c5b3e791@linaro.org>
 <696a7481-60f0-859c-c0d0-590c6ae69689@simark.ca>
 <a2958bb8-b424-7d00-9238-d07381edaf07@palves.net>
From: Simon Marchi <simark@simark.ca>
Message-ID: <eb7441e8-5109-c474-d2f2-08c08d49da3c@simark.ca>
Date: Wed, 16 Sep 2020 16:44:23 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <a2958bb8-b424-7d00-9238-d07381edaf07@palves.net>
Content-Type: text/plain; charset=utf-8
Content-Language: tl
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Sep 2020 20:44:25 -0000

On 2020-09-16 7:01 a.m., Pedro Alves wrote:
> On 9/16/20 3:50 AM, Simon Marchi wrote:
>> On 2020-09-15 5:28 p.m., Luis Machado wrote:
>>> I think you missed adjusting the stale references in gdb/gdb-gdb.py.in.
>>
>> I wasn't sure what you meant, but I suppose it is:
>>
>> 115         fields.append("instance_flags = %s"
>> 116                       % TypeFlagsPrinter(self.val['instance_flags']))
>>
>> ? Indeed, instance_flags there should be changed to m_instance_flags.
>
> My fault then, sorry about that.
>
>> Does the
>> patch below look good?
>
> Looks fine to me.
>
> Thanks for fixing it.

Thanks, I pushed it.

Simon