Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/2] Return gdbpy_ref in a couple more places
Date: Wed, 24 Oct 2018 20:03:00 -0000	[thread overview]
Message-ID: <ea59b044e5250c98f75dbded987a7b9f@polymtl.ca> (raw)
In-Reply-To: <cover.1540407540.git.andrew.burgess@embecosm.com>

On 2018-10-24 15:12, Andrew Burgess wrote:
> I spotted a couple of places where a gdbpy_ref was released in one
> function only to be recreated again later.
> 
> Thanks,
> Andrew

Thanks, both patches LGTM.  However, please update the commit titles to 
include the function name (e.g. "gdb/python: Make cmdpy_completer_helper 
return gdbpy_ref<>").  It's clearer than having multiple commits with 
the same title.

Simon


      parent reply	other threads:[~2018-10-24 20:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-24 19:12 Andrew Burgess
2018-10-24 19:12 ` [PATCH 1/2] gdb/python: Make a function return gdbpy_ref<> Andrew Burgess
2018-10-24 19:12 ` [PATCH 2/2] " Andrew Burgess
2018-10-24 20:03 ` Simon Marchi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea59b044e5250c98f75dbded987a7b9f@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox