From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87797 invoked by alias); 24 Oct 2018 20:03:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87775 invoked by uid 89); 24 Oct 2018 20:03:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 24 Oct 2018 20:03:09 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w9OK32SH027626 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 24 Oct 2018 16:03:07 -0400 Received: by simark.ca (Postfix, from userid 112) id 921ED1E514; Wed, 24 Oct 2018 16:03:02 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 97C771E514; Wed, 24 Oct 2018 16:03:01 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 24 Oct 2018 20:03:00 -0000 From: Simon Marchi To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/2] Return gdbpy_ref in a couple more places In-Reply-To: References: Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00564.txt.bz2 On 2018-10-24 15:12, Andrew Burgess wrote: > I spotted a couple of places where a gdbpy_ref was released in one > function only to be recreated again later. > > Thanks, > Andrew Thanks, both patches LGTM. However, please update the commit titles to include the function name (e.g. "gdb/python: Make cmdpy_completer_helper return gdbpy_ref<>"). It's clearer than having multiple commits with the same title. Simon