Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb] Mention --with/without-system-readline for --configuration
Date: Tue, 30 May 2023 09:36:32 -0400	[thread overview]
Message-ID: <ea4b1652-1cb6-cc16-79b2-75277e4de540@polymtl.ca> (raw)
In-Reply-To: <20230530093344.12517-1-tdevries@suse.de>

On 5/30/23 05:33, Tom de Vries wrote:
> Simon reported that the new test-case gdb.tui/pr30056.exp fails with system
> readline.
> 
> This is because the test-case requires a fix in readline that's present in our
> in-repo copy of readline, but most likely not in any system readline yet.
> 
> Fix this by:
> - mentioning --with-system-readline or --without-system-readline in the
>   configuration string.
> - adding a new proc with_system_readline that makes this information available
>   in the testsuite.
> - using this in test-case gdb.tui/pr30056.exp to declare it unsupported for
>   --with-system-readline.
> 
> Tested on x86_64-linux.
> 
> Reported-By: Simon Marchi <simon.marchi@efficios.com>

I confirm this makes the test skipped on my machine.

Once the fix is merged and in a readline release, could we make the skip
conditional on the readline version?  We could have a maintenance
command or something like that that outputs RL_READLINE_VERSION, and
skip only for old readline versions.

Simon

  reply	other threads:[~2023-05-30 13:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-30  9:33 Tom de Vries via Gdb-patches
2023-05-30 13:36 ` Simon Marchi via Gdb-patches [this message]
2023-05-30 15:41   ` Tom de Vries via Gdb-patches
2023-05-30 15:43     ` Simon Marchi via Gdb-patches
2023-05-31  5:57       ` Tom de Vries via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea4b1652-1cb6-cc16-79b2-75277e4de540@polymtl.ca \
    --to=gdb-patches@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox