From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SRO/NgT8dWRjyRgAWB0awg (envelope-from ) for ; Tue, 30 May 2023 09:37:08 -0400 Received: by simark.ca (Postfix, from userid 112) id CF1991E11E; Tue, 30 May 2023 09:37:08 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=JJMOOmFs; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_HI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3A78A1E0D4 for ; Tue, 30 May 2023 09:37:08 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E9DFA385840E for ; Tue, 30 May 2023 13:37:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E9DFA385840E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1685453827; bh=bV9GNcKuDbwcaUhQ6WCRKX9VYeZrq0d3gx4SDdQw6YY=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=JJMOOmFsPlH7iatZIhtbjtWZMficbo7hbShxzhIDGEpQlye4p82Cwpy+D2vbrf/fp vTy8PMKAdWLmwuc1yoWKVJiR0WxD/QAx9iUdt/m3HszkYT29ceANHmIBOtUsQC+ZBS qfj6XCOwH/olT4xKT6NfWJhTtDGFRBSL70+vyC/0= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 43D2C3858D20 for ; Tue, 30 May 2023 13:36:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 43D2C3858D20 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 34UDaW58032454 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 30 May 2023 09:36:37 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 34UDaW58032454 Received: from [10.0.0.170] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 854A81E0D4; Tue, 30 May 2023 09:36:32 -0400 (EDT) Message-ID: Date: Tue, 30 May 2023 09:36:32 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH] [gdb] Mention --with/without-system-readline for --configuration Content-Language: fr To: Tom de Vries , gdb-patches@sourceware.org References: <20230530093344.12517-1-tdevries@suse.de> In-Reply-To: <20230530093344.12517-1-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 30 May 2023 13:36:32 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 5/30/23 05:33, Tom de Vries wrote: > Simon reported that the new test-case gdb.tui/pr30056.exp fails with system > readline. > > This is because the test-case requires a fix in readline that's present in our > in-repo copy of readline, but most likely not in any system readline yet. > > Fix this by: > - mentioning --with-system-readline or --without-system-readline in the > configuration string. > - adding a new proc with_system_readline that makes this information available > in the testsuite. > - using this in test-case gdb.tui/pr30056.exp to declare it unsupported for > --with-system-readline. > > Tested on x86_64-linux. > > Reported-By: Simon Marchi I confirm this makes the test skipped on my machine. Once the fix is merged and in a readline release, could we make the skip conditional on the readline version? We could have a maintenance command or something like that that outputs RL_READLINE_VERSION, and skip only for old readline versions. Simon