From: Pedro Alves <palves@redhat.com>
To: Markus Metzger <markus.t.metzger@intel.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 1/2] thread: add can_access_registers_ptid
Date: Wed, 25 Jan 2017 14:33:00 -0000 [thread overview]
Message-ID: <ea040f97-0730-7843-6b6c-fc2bd84274c5@redhat.com> (raw)
In-Reply-To: <1484923135-31270-2-git-send-email-markus.t.metzger@intel.com>
On 01/20/2017 02:38 PM, Markus Metzger wrote:
> +/* See gdbthread.h. */
> +
> +int
> +can_access_registers_ptid (ptid_t ptid)
> +{
> + /* No thread, no registers. */
> + if (ptid_equal (ptid, null_ptid))
> + return 0;
> +
> + /* Don't try to read from a dead thread. */
> + if (is_exited (ptid))
> + return 0;
> +
> + /* ... or from a spinning thread. FIXME: see validate_registers_access. */
> + if (is_executing (ptid))
> + return 0;
> +
> + return 1;
> +}
Use "bool" and true/false. OK with that change.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2017-01-25 14:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 14:39 [PATCH v2 0/2] thread, btrace: allow "record btrace" for running threads Markus Metzger
2017-01-20 14:39 ` [PATCH v2 1/2] thread: add can_access_registers_ptid Markus Metzger
2017-01-25 14:33 ` Pedro Alves [this message]
2017-01-20 14:39 ` [PATCH v2 2/2] btrace: allow recording to be started for running threads Markus Metzger
2017-01-25 14:32 ` Pedro Alves
2017-01-25 14:36 ` Pedro Alves
2017-01-25 15:53 ` Metzger, Markus T
2017-01-25 16:13 ` Pedro Alves
2017-01-26 14:54 ` Metzger, Markus T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea040f97-0730-7843-6b6c-fc2bd84274c5@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox