From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-136471-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 120165 invoked by alias); 25 Jan 2017 14:33:56 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 120149 invoked by uid 89); 25 Jan 2017 14:33:55 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-5.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Jan 2017 14:33:55 +0000
Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id F29EC804F6;	Wed, 25 Jan 2017 14:33:54 +0000 (UTC)
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4])	by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v0PEXoH4012164;	Wed, 25 Jan 2017 09:33:51 -0500
Subject: Re: [PATCH v2 1/2] thread: add can_access_registers_ptid
To: Markus Metzger <markus.t.metzger@intel.com>, gdb-patches@sourceware.org
References: <1484923135-31270-1-git-send-email-markus.t.metzger@intel.com> <1484923135-31270-2-git-send-email-markus.t.metzger@intel.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <ea040f97-0730-7843-6b6c-fc2bd84274c5@redhat.com>
Date: Wed, 25 Jan 2017 14:33:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <1484923135-31270-2-git-send-email-markus.t.metzger@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2017-01/txt/msg00527.txt.bz2

On 01/20/2017 02:38 PM, Markus Metzger wrote:

> +/* See gdbthread.h.  */
> +
> +int
> +can_access_registers_ptid (ptid_t ptid)
> +{
> +  /* No thread, no registers.  */
> +  if (ptid_equal (ptid, null_ptid))
> +    return 0;
> +
> +  /* Don't try to read from a dead thread.  */
> +  if (is_exited (ptid))
> +    return 0;
> +
> +  /* ... or from a spinning thread.  FIXME: see validate_registers_access.  */
> +  if (is_executing (ptid))
> +    return 0;
> +
> +  return 1;
> +}

Use "bool" and true/false.  OK with that change.

Thanks,
Pedro Alves