From: Luis Machado <lgustavo@codesourcery.com>
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH,v3] Harden tests that deal with memory regions
Date: Thu, 26 Jan 2017 19:54:00 -0000 [thread overview]
Message-ID: <e8134ab4-dec9-0ac1-28e0-2a6e5dd4cb5e@codesourcery.com> (raw)
In-Reply-To: <bb9c98e9-5ca2-b4b1-e8b1-464b843a7b0d@redhat.com>
On 01/26/2017 01:32 PM, Pedro Alves wrote:
> OK with ...
>
>> Changes in v3:
>>
>> - Fixed up comments.
>> - Renamed lib/gdb-memory.exp to lib/memory.exp.
>> - Moved memory region deletion closer to where we run to main in
>> gdb.base/breakpoint-in-ro-regions.exp.
>>
>> Changes in v2:
>>
>> - Addressed comments by Pedro.
>> - Removed stale comments, fixed copyright year.
>> - Updated comment for proc delete_memory_regions.
>>
>
> ... these removed from the final commit log ...
>
>>
>> OK?
>
> ... and this too, and ...
>
>
>> +++ b/gdb/testsuite/lib/memory.exp
>> @@ -0,0 +1,33 @@
>> +# Copyright 2012 Free Software Foundation, Inc.
>
> 2012-2017
Thanks! Pushed to master as
e309aa6524f8becadf6f1b75060a74be4c221899 with the above addressed.
prev parent reply other threads:[~2017-01-26 19:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 21:24 [PATCH] " Luis Machado
2017-01-26 13:17 ` Pedro Alves
2017-01-26 17:37 ` Luis Machado
2017-01-26 17:47 ` Pedro Alves
2017-01-26 18:06 ` Luis Machado
2017-01-26 17:41 ` [PATCH,v2] " Luis Machado
2017-01-26 18:03 ` [PATCH,v3] " Luis Machado
2017-01-26 19:32 ` Pedro Alves
2017-01-26 19:54 ` Luis Machado [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8134ab4-dec9-0ac1-28e0-2a6e5dd4cb5e@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox