From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-136548-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10407 invoked by alias); 26 Jan 2017 19:54:26 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 10398 invoked by uid 89); 26 Jan 2017 19:54:25 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*f:sk:bb9c98e, H*MI:sk:bb9c98e, H*i:sk:bb9c98e
X-HELO: relay1.mentorg.com
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Jan 2017 19:54:24 +0000
Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203])	by relay1.mentorg.com with esmtp 	id 1cWq7h-0007S3-Te from Luis_Gustavo@mentor.com ; Thu, 26 Jan 2017 11:54:21 -0800
Received: from [172.30.8.148] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Thu, 26 Jan 2017 11:54:18 -0800
Reply-To: Luis Machado <lgustavo@codesourcery.com>
Subject: Re: [PATCH,v3] Harden tests that deal with memory regions
References: <1485206680-4402-1-git-send-email-lgustavo@codesourcery.com> <1485453806-31216-1-git-send-email-lgustavo@codesourcery.com> <bb9c98e9-5ca2-b4b1-e8b1-464b843a7b0d@redhat.com>
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
From: Luis Machado <lgustavo@codesourcery.com>
Message-ID: <e8134ab4-dec9-0ac1-28e0-2a6e5dd4cb5e@codesourcery.com>
Date: Thu, 26 Jan 2017 19:54:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <bb9c98e9-5ca2-b4b1-e8b1-464b843a7b0d@redhat.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: svr-orw-mbx-04.mgc.mentorg.com (147.34.90.204) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203)
X-IsSubscribed: yes
X-SW-Source: 2017-01/txt/msg00604.txt.bz2

On 01/26/2017 01:32 PM, Pedro Alves wrote:
> OK with ...
>
>> Changes in v3:
>>
>> - Fixed up comments.
>> - Renamed lib/gdb-memory.exp to lib/memory.exp.
>> - Moved memory region deletion closer to where we run to main in
>>   gdb.base/breakpoint-in-ro-regions.exp.
>>
>> Changes in v2:
>>
>> - Addressed comments by Pedro.
>> - Removed stale comments, fixed copyright year.
>> - Updated comment for proc delete_memory_regions.
>>
>
> ... these removed from the final commit log ...
>
>>
>> OK?
>
> ... and this too, and ...
>
>
>> +++ b/gdb/testsuite/lib/memory.exp
>> @@ -0,0 +1,33 @@
>> +# Copyright 2012 Free Software Foundation, Inc.
>
> 2012-2017

Thanks! Pushed to master as
e309aa6524f8becadf6f1b75060a74be4c221899 with the above addressed.