Re: [PING][PATCH] [gdb/tdep] Use cached breakpoint kind in breakpoint_kind

[Tom de Vries <tdevries@suse.de>]

On 8/5/24 19:08, Simon Marchi wrote:
> On 8/5/24 12:00 PM, Tom de Vries wrote:
>> I've given this patch some more thought, and I think I have come up
>> with a counter example.
>>
>> Say you have a breakpoint kind that is different depending on the
>> alignment, one kind for "addr & 0x4 == 0x0" and another kind for "addr
>> & 0x4 == 0x2".
>>
>> Then when relocating the exec, the kind might change, but due to the
>> caching introduced by this patch, we might be incorrectly using the
>> same kind as before the relocation.
> 
> Did you see this kind of relocation in practice?  Typically, executables
> get relocated with an offset that is a multiple of the page size, or
> something big like that, so it wouldn't affect alignment in such way.

It's a theoretical example, so it's easy to adapt it be affected by 
relocation with page size multiples, but it remains theoretical.

Thanks,
- Tom