From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id eFsNGhTOsWaOxD0AWB0awg (envelope-from ) for ; Tue, 06 Aug 2024 03:17:40 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=EPM8VS0I; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Tc45xwKb; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=EPM8VS0I; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Tc45xwKb; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 63A0C1E0D0; Tue, 6 Aug 2024 03:17:40 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4D84A1E08C for ; Tue, 6 Aug 2024 03:17:38 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BA6933858289 for ; Tue, 6 Aug 2024 07:17:37 +0000 (GMT) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 8ECAB3858401 for ; Tue, 6 Aug 2024 07:17:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8ECAB3858401 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8ECAB3858401 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1722928638; cv=none; b=gr0id+ccBoGrDZ6GkhOSdB7+idudoheIyBq6MkezoWf9thGLwHvq2CuuNYBLfHgbGEmC30EM1uppTaxF5reiMJhCGuOwX4P6r15hcZ9i/paV9Lo8my9nwJSBrljcY3MqWQM0Ldajg4Q4/WJXL04gZOUZAyFldQKJlg/fLUmTBws= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1722928638; c=relaxed/simple; bh=oy4bQzqI7Zr2X9suZbfATRLF24yIHERRsbsw8+mkOrk=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=DYhDETOvOYjnvLHQZjrncc1Tf2siM6bR0Kxj5kOaAcrU4l0ZdUtvkFFSAsJ+osooHfHLOXscaaLoiQVMhFaGRCxkzX3Qz+JvLUHLmGLIWp3eftFoM2NXcJC2z7/U+pdGuHse3IH8+RJs+aXCDmViE4bVqLJLJf105IbEYNxSJYA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4329721C16; Tue, 6 Aug 2024 07:17:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1722928635; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xMYKf58zXUmB4c5zYzHsQKYfAUo6apgPEcv/DsxjLfI=; b=EPM8VS0IDVfGpbZMoNksvPcc9BsChmX0u6U/oV/TntVjhHiD/xKYU9g/k6/NROHfTafr4Q mMZZ/ReR72/yPOvVN69TsAJBUgWmA4GXdZCdDP1b5pB+iWlQy9ZL/MGU35w1+Blopt9N53 mowLGy5XBo7L+HKfvScZwRQbsq9g0+A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1722928635; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xMYKf58zXUmB4c5zYzHsQKYfAUo6apgPEcv/DsxjLfI=; b=Tc45xwKbmN1J+yIt9CHMa28oJibC2IK6GL3v+68lAjTYFUI92qDgGtNA+W8YBAqjt2Li27 3UT1+dBofuUJ6+Dg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1722928635; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xMYKf58zXUmB4c5zYzHsQKYfAUo6apgPEcv/DsxjLfI=; b=EPM8VS0IDVfGpbZMoNksvPcc9BsChmX0u6U/oV/TntVjhHiD/xKYU9g/k6/NROHfTafr4Q mMZZ/ReR72/yPOvVN69TsAJBUgWmA4GXdZCdDP1b5pB+iWlQy9ZL/MGU35w1+Blopt9N53 mowLGy5XBo7L+HKfvScZwRQbsq9g0+A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1722928635; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xMYKf58zXUmB4c5zYzHsQKYfAUo6apgPEcv/DsxjLfI=; b=Tc45xwKbmN1J+yIt9CHMa28oJibC2IK6GL3v+68lAjTYFUI92qDgGtNA+W8YBAqjt2Li27 3UT1+dBofuUJ6+Dg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2BA0D13981; Tue, 6 Aug 2024 07:17:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id vhQrCfvNsWZPVwAAD6G6ig (envelope-from ); Tue, 06 Aug 2024 07:17:15 +0000 Message-ID: Date: Tue, 6 Aug 2024 09:17:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PING][PATCH] [gdb/tdep] Use cached breakpoint kind in breakpoint_kind To: Simon Marchi , gdb-patches@sourceware.org References: <20240607143821.29797-1-tdevries@suse.de> <5188e7e4-5d7b-4d9a-b81b-9393d7b2ff77@suse.de> <69569020-ae82-40c5-aad6-9a90099947db@suse.de> Content-Language: en-US From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Level: X-Spamd-Result: default: False [-1.29 / 50.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.998]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo] X-Spam-Score: -1.29 X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/5/24 19:08, Simon Marchi wrote: > On 8/5/24 12:00 PM, Tom de Vries wrote: >> I've given this patch some more thought, and I think I have come up >> with a counter example. >> >> Say you have a breakpoint kind that is different depending on the >> alignment, one kind for "addr & 0x4 == 0x0" and another kind for "addr >> & 0x4 == 0x2". >> >> Then when relocating the exec, the kind might change, but due to the >> caching introduced by this patch, we might be incorrectly using the >> same kind as before the relocation. > > Did you see this kind of relocation in practice? Typically, executables > get relocated with an offset that is a multiple of the page size, or > something big like that, so it wouldn't affect alignment in such way. It's a theoretical example, so it's easy to adapt it be affected by relocation with page size multiples, but it remains theoretical. Thanks, - Tom