From: Doug Evans <dje@google.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] break-interp.exp: handle /usr/sbin/prelink.bin
Date: Thu, 18 Mar 2010 07:26:00 -0000 [thread overview]
Message-ID: <e394668d1003180026k4c44b4dldf19abcb8ac1a5ed@mail.gmail.com> (raw)
In-Reply-To: <201003180315.31166.vapier@gentoo.org>
On Thu, Mar 18, 2010 at 12:15 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Thursday 18 March 2010 02:15:07 Doug Evans wrote:
>> - if {$result == 1 && [regexp {^(/usr/sbin/prelink: [^ ]* does not have
>> .gnu.prelink_undo section\n?)*$} $output]} {
>> + if {$result == 1 && [regexp {^(/usr/sbin/prelink[^ ]*: [^ ]* does not
>> have .gnu.prelink_undo section\n?)*$} $output]} {
>
> since the prelink filename shouldnt have a colon in it, should that be used in
> the regex instead ?
> /usr/sbin/prelink[^:]*:
> -mike
Either is arguably wrong IMO. Why can't the program have a colon or
space in its name?
But I don't have a strong opinion on which one to actually use, or
something else.
next prev parent reply other threads:[~2010-03-18 7:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-18 6:15 Doug Evans
2010-03-18 7:15 ` Mike Frysinger
2010-03-18 7:26 ` Doug Evans [this message]
2010-03-18 7:43 ` Mike Frysinger
2010-03-18 13:59 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e394668d1003180026k4c44b4dldf19abcb8ac1a5ed@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox