From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-71208-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4514 invoked by alias); 18 Mar 2010 07:26:31 -0000
Received: (qmail 4505 invoked by uid 22791); 18 Mar 2010 07:26:30 -0000
X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 	tests=BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.35)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 18 Mar 2010 07:26:26 +0000
Received: from wpaz9.hot.corp.google.com (wpaz9.hot.corp.google.com [172.24.198.73]) 	by smtp-out.google.com with ESMTP id o2I7QMIT013496 	for <gdb-patches@sourceware.org>; Thu, 18 Mar 2010 08:26:23 +0100
Received: from wye20 (wye20.prod.google.com [10.241.226.20]) 	by wpaz9.hot.corp.google.com with ESMTP id o2I7QLCL008449 	for <gdb-patches@sourceware.org>; Thu, 18 Mar 2010 00:26:21 -0700
Received: by wye20 with SMTP id 20so839486wye.9         for <gdb-patches@sourceware.org>; Thu, 18 Mar 2010 00:26:20 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.216.88.143 with SMTP id a15mr1145695wef.6.1268897180791; Thu,  	18 Mar 2010 00:26:20 -0700 (PDT)
In-Reply-To: <201003180315.31166.vapier@gentoo.org>
References: <20100318061507.102F084414@ruffy.mtv.corp.google.com> 	 <201003180315.31166.vapier@gentoo.org>
Date: Thu, 18 Mar 2010 07:26:00 -0000
Message-ID: <e394668d1003180026k4c44b4dldf19abcb8ac1a5ed@mail.gmail.com>
Subject: Re: [patch] break-interp.exp: handle /usr/sbin/prelink.bin
From: Doug Evans <dje@google.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-System-Of-Record: true
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-03/txt/msg00653.txt.bz2

On Thu, Mar 18, 2010 at 12:15 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Thursday 18 March 2010 02:15:07 Doug Evans wrote:
>> - =A0 =A0if {$result =3D=3D 1 && [regexp {^(/usr/sbin/prelink: [^ ]* doe=
s not have
>> .gnu.prelink_undo section\n?)*$} $output]} {
>> + =A0 =A0if {$result =3D=3D 1 && [regexp {^(/usr/sbin/prelink[^ ]*: [^ ]=
* does not
>> have .gnu.prelink_undo section\n?)*$} $output]} {
>
> since the prelink filename shouldnt have a colon in it, should that be us=
ed in
> the regex instead ?
> /usr/sbin/prelink[^:]*:
> -mike

Either is arguably wrong IMO.  Why can't the program have a colon or
space in its name?
But I don't have a strong opinion on which one to actually use, or
something else.