From: Doug Evans <dje@google.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: GDB <gdb-patches@sourceware.org>, "H.J. Lu" <hjl.tools@gmail.com>
Subject: Re: PATCH: PR gdb/10649: GDB_DATADIR_PATH is used, but never defined
Date: Fri, 02 Oct 2009 02:12:00 -0000 [thread overview]
Message-ID: <e394668d0910011912q145d881ardb4da94c5d02f335@mail.gmail.com> (raw)
In-Reply-To: <20090916215205.GA27211@lucon.org>
On Wed, Sep 16, 2009 at 2:52 PM, H.J. Lu <hongjiu.lu@intel.com> wrote:
> Hi,
>
> I am checking in this patch as an obvious fix.
>
> Thanks.
>
>
> H.J.
> ---
> 2009-09-16 H.J. Lu <hongjiu.lu@intel.com>
>
> PR gdb/10649
> * Makefile.in (GDB_DATADIR_PATH): Renamed to ...
> (GDB_DATADIR): This.
> (xml-syscall-install): Updated.
>
> --- ./Makefile.in.foo 2009-09-16 14:07:50.000000000 -0700
> +++ ./Makefile.in 2009-09-16 14:47:17.000000000 -0700
> @@ -167,7 +167,7 @@ TARGET_SYSTEM_ROOT = @TARGET_SYSTEM_ROOT
> TARGET_SYSTEM_ROOT_DEFINE = @TARGET_SYSTEM_ROOT_DEFINE@
>
> # Did the user give us a --with-gdb-datadir option?
> -GDB_DATADIR_PATH = @GDB_DATADIR_PATH@
> +GDB_DATADIR = @GDB_DATADIR@
>
> # Helper code from gnulib.
> LIBGNU = gnulib/libgnu.a
> @@ -899,13 +899,13 @@ xml-syscall-copy:
> .PHONY: xml-syscall-install
> xml-syscall-install:
> $(SHELL) $(srcdir)/../mkinstalldirs \
> - $(DESTDIR)$(GDB_DATADIR_PATH)/$(XML_SYSCALLS_DIR) ; \
> + $(DESTDIR)$(GDB_DATADIR)/$(XML_SYSCALLS_DIR) ; \
> list='$(XML_SYSCALLS_FILES)' ; \
> for file in $$list ; do \
> f=$(srcdir)/$(XML_SYSCALLS_DIR)/$$file ; \
> if test -f $$f ; then \
> $(INSTALL_DATA) $$f \
> - $(DESTDIR)$(GDB_DATADIR_PATH)/$(XML_SYSCALLS_DIR) ; \
> + $(DESTDIR)$(GDB_DATADIR)/$(XML_SYSCALLS_DIR) ; \
> fi ; \
> done ;
Joel, I think it's critical that this goes into the release branch.
Otherwise, "make install" creates a directory called
@GDB_DATADIR_PATH@ in the install tree.
next prev parent reply other threads:[~2009-10-02 2:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-16 21:52 H.J. Lu
2009-10-02 2:12 ` Doug Evans [this message]
2009-10-02 22:08 ` Joel Brobecker
2009-10-02 2:38 ` Sérgio Durigan Júnior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e394668d0910011912q145d881ardb4da94c5d02f335@mail.gmail.com \
--to=dje@google.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox