From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-67423-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29425 invoked by alias); 2 Oct 2009 02:12:12 -0000
Received: (qmail 29414 invoked by uid 22791); 2 Oct 2009 02:12:12 -0000
X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 	tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 02 Oct 2009 02:12:07 +0000
Received: from zps19.corp.google.com (zps19.corp.google.com [172.25.146.19]) 	by smtp-out.google.com with ESMTP id n922C474018005 	for <gdb-patches@sourceware.org>; Fri, 2 Oct 2009 03:12:05 +0100
Received: from pzk3 (pzk3.prod.google.com [10.243.19.131]) 	by zps19.corp.google.com with ESMTP id n922C1FB014715 	for <gdb-patches@sourceware.org>; Thu, 1 Oct 2009 19:12:02 -0700
Received: by pzk3 with SMTP id 3so750840pzk.20         for <gdb-patches@sourceware.org>; Thu, 01 Oct 2009 19:12:01 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.140.126.17 with SMTP id y17mr721481rvc.2.1254449521746; Thu,  	01 Oct 2009 19:12:01 -0700 (PDT)
In-Reply-To: <20090916215205.GA27211@lucon.org>
References: <20090916215205.GA27211@lucon.org>
Date: Fri, 02 Oct 2009 02:12:00 -0000
Message-ID: <e394668d0910011912q145d881ardb4da94c5d02f335@mail.gmail.com>
Subject: Re: PATCH: PR gdb/10649: GDB_DATADIR_PATH is used, but never defined
From: Doug Evans <dje@google.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: GDB <gdb-patches@sourceware.org>, "H.J. Lu" <hjl.tools@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-System-Of-Record: true
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-10/txt/msg00046.txt.bz2

On Wed, Sep 16, 2009 at 2:52 PM, H.J. Lu <hongjiu.lu@intel.com> wrote:
> Hi,
>
> I am checking in this patch as an obvious fix.
>
> Thanks.
>
>
> H.J.
> ---
> 2009-09-16 =A0H.J. Lu =A0<hongjiu.lu@intel.com>
>
> =A0 =A0 =A0 =A0PR gdb/10649
> =A0 =A0 =A0 =A0* Makefile.in (GDB_DATADIR_PATH): Renamed to ...
> =A0 =A0 =A0 =A0(GDB_DATADIR): This.
> =A0 =A0 =A0 =A0(xml-syscall-install): Updated.
>
> --- ./Makefile.in.foo =A0 2009-09-16 14:07:50.000000000 -0700
> +++ ./Makefile.in =A0 =A0 =A0 2009-09-16 14:47:17.000000000 -0700
> @@ -167,7 +167,7 @@ TARGET_SYSTEM_ROOT =3D @TARGET_SYSTEM_ROOT
> =A0TARGET_SYSTEM_ROOT_DEFINE =3D @TARGET_SYSTEM_ROOT_DEFINE@
>
> =A0# Did the user give us a --with-gdb-datadir option?
> -GDB_DATADIR_PATH =3D @GDB_DATADIR_PATH@
> +GDB_DATADIR =3D @GDB_DATADIR@
>
> =A0# Helper code from gnulib.
> =A0LIBGNU =3D gnulib/libgnu.a
> @@ -899,13 +899,13 @@ xml-syscall-copy:
> =A0.PHONY: xml-syscall-install
> =A0xml-syscall-install:
> =A0 =A0 =A0 =A0$(SHELL) $(srcdir)/../mkinstalldirs \
> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 $(DESTDIR)$(GDB_DATADIR_PATH)/$(XML_SYSCALL=
S_DIR) ; \
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 $(DESTDIR)$(GDB_DATADIR)/$(XML_SYSCALLS_DIR=
) ; \
> =A0 =A0 =A0 =A0list=3D'$(XML_SYSCALLS_FILES)' ; \
> =A0 =A0 =A0 =A0for file in $$list ; do \
> =A0 =A0 =A0 =A0 =A0f=3D$(srcdir)/$(XML_SYSCALLS_DIR)/$$file ; \
> =A0 =A0 =A0 =A0 =A0if test -f $$f ; then \
> =A0 =A0 =A0 =A0 =A0 =A0$(INSTALL_DATA) $$f \
> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 $(DESTDIR)$(GDB_DATADIR_PATH)/$(XML_SYSCALL=
S_DIR) ; \
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 $(DESTDIR)$(GDB_DATADIR)/$(XML_SYSCALLS_DIR=
) ; \
> =A0 =A0 =A0 =A0 =A0fi ; \
> =A0 =A0 =A0 =A0done ;

Joel, I think it's critical that this goes into the release branch.

Otherwise, "make install" creates a directory called
@GDB_DATADIR_PATH@ in the install tree.