From: Doug Evans <dje@google.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Unbreak 'catch syscall' + multi-threading
Date: Thu, 01 Oct 2009 09:51:00 -0000 [thread overview]
Message-ID: <e394668d0910010250m4d5b7e21s5e95e1ce2efa55f8@mail.gmail.com> (raw)
In-Reply-To: <200910010148.16982.pedro@codesourcery.com>
On Wed, Sep 30, 2009 at 5:48 PM, Pedro Alves <pedro@codesourcery.com> wrote:
> As we were discussing yesterday, 'catch syscall' is unfortunately
> broken with multi-threading in the mix, plus it has a few other
> problems (present on 7.0 too, of course). This patch fixes all the
> issues I found.
Thanks.
> The code now uses (SIGTRAP | 0x80) directly in the couple
> of places that need it, since that is exactly how the event is
> described in the ptrace man page.
nit: 0x80 is still a magic number no different than others (ISTM anyway).
IWBN to keep TRAP_IS_SYSCALL (change the name however you like &/|
only record 0x80 in it if you like).
next prev parent reply other threads:[~2009-10-01 9:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 0:48 Pedro Alves
2009-10-01 9:51 ` Doug Evans [this message]
2009-10-02 16:55 ` Pedro Alves
2009-10-03 3:17 ` Sérgio Durigan Júnior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e394668d0910010250m4d5b7e21s5e95e1ce2efa55f8@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox