From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22378 invoked by alias); 1 Oct 2009 09:51:06 -0000 Received: (qmail 22368 invoked by uid 22791); 1 Oct 2009 09:51:05 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Oct 2009 09:51:01 +0000 Received: from spaceape14.eur.corp.google.com (spaceape14.eur.corp.google.com [172.28.16.148]) by smtp-out.google.com with ESMTP id n919owhw025526 for ; Thu, 1 Oct 2009 10:50:58 +0100 Received: from pzk10 (pzk10.prod.google.com [10.243.19.138]) by spaceape14.eur.corp.google.com with ESMTP id n919o3MP020437 for ; Thu, 1 Oct 2009 02:50:56 -0700 Received: by pzk10 with SMTP id 10so3924778pzk.19 for ; Thu, 01 Oct 2009 02:50:55 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.194.5 with SMTP id r5mr78206rvf.125.1254390655682; Thu, 01 Oct 2009 02:50:55 -0700 (PDT) In-Reply-To: <200910010148.16982.pedro@codesourcery.com> References: <200910010148.16982.pedro@codesourcery.com> Date: Thu, 01 Oct 2009 09:51:00 -0000 Message-ID: Subject: Re: Unbreak 'catch syscall' + multi-threading From: Doug Evans To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00006.txt.bz2 On Wed, Sep 30, 2009 at 5:48 PM, Pedro Alves wrote: > As we were discussing yesterday, 'catch syscall' is unfortunately > broken with multi-threading in the mix, plus it has a few other > problems (present on 7.0 too, of course). =A0This patch fixes all the > issues I found. Thanks. > The code now uses (SIGTRAP | 0x80) directly in the couple > =A0 of places that need it, since that is exactly how the event is > =A0 described in the ptrace man page. nit: 0x80 is still a magic number no different than others (ISTM anyway). IWBN to keep TRAP_IS_SYSCALL (change the name however you like &/| only record 0x80 in it if you like).