From: Doug Evans <dje@google.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: Mark outer frames
Date: Tue, 01 Sep 2009 22:41:00 -0000 [thread overview]
Message-ID: <e394668d0909011541v649ada12mab74e87b39a88f@mail.gmail.com> (raw)
In-Reply-To: <20090831225115.GA4365@adacore.com>
On Mon, Aug 31, 2009 at 3:51 PM, Joel Brobecker<brobecker@adacore.com> wrote:
>>[...]
>> So the frame
>> id is null_frame_id - which is overloaded to mean 'unknown id' and
>> 'no frame at all'. The value checks are using it one way and the
>> unwinder is using it the other.
>>[...]
>> Is it too ugly to live?
>
> Not sure. I haven't taken the time to look at the patch itself
> (trying to focus on the blocking items for the next release),
> but if no one else has a better idea... We could try to brainstorm
> on that after the branch has been cut...
fwiw,
I've tripped over this myself a couple of times ("this" being the overloading).
I think this patch, or something akin to it, is needed.
next prev parent reply other threads:[~2009-09-01 22:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-28 22:16 Daniel Jacobowitz
2009-08-29 7:24 ` Eli Zaretskii
2009-08-31 22:54 ` Joel Brobecker
2009-09-01 22:41 ` Doug Evans [this message]
2009-09-02 17:03 ` Joel Brobecker
2009-09-02 17:33 ` Daniel Jacobowitz
2009-09-03 22:52 ` Joel Brobecker
2009-09-10 2:29 ` [gdb-7.0] " Joel Brobecker
2009-09-10 19:12 ` Daniel Jacobowitz
2009-09-10 22:41 ` Joel Brobecker
2009-09-12 22:13 ` [gdb-7.0/doco] " Joel Brobecker
2009-09-12 22:14 ` Joel Brobecker
2009-09-13 3:11 ` Eli Zaretskii
2009-09-13 16:29 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e394668d0909011541v649ada12mab74e87b39a88f@mail.gmail.com \
--to=dje@google.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox