Re: [RFA] rename find_thread_pid to find_thread_ptid

[Doug Evans <dje@google.com>]

On Wed, May 6, 2009 at 12:02 PM, Joel Brobecker <brobecker@adacore.com> wrote:
>> Anyone mind a global renaming of find_thread_pid to find_thread_ptid?
>
> I don't mind the renaming, but if we're going to rename it, what do
> people thing about "find_thread_from_ptid". I always get confused by
> the function name because it makes me think that the function returns
> the pid/ptid instead of returning the thread from the ptid...
>
> That's just a suggestion and I don't want to start another bikeshed
> discussion. The name you suggest is already better than the old name,
> so I'm not objecting to your initial suggestion.

I don't mind that renaming either, I prefer it too.
But if one goes down that path then there's more than just
find_thread_ptid to rename, so I left that for another day.
Perhaps more work, but with the right tools it's rather trivial, so I
went with consistency with what's there today and just fixed the
pid->ptid bug.