From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29187 invoked by alias); 6 May 2009 20:25:43 -0000 Received: (qmail 29157 invoked by uid 22791); 6 May 2009 20:25:41 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 May 2009 20:25:32 +0000 Received: from spaceape12.eur.corp.google.com (spaceape12.eur.corp.google.com [172.28.16.146]) by smtp-out.google.com with ESMTP id n46KPT5g021905 for ; Wed, 6 May 2009 13:25:29 -0700 Received: from qw-out-1920.google.com (qwk4.prod.google.com [10.241.195.132]) by spaceape12.eur.corp.google.com with ESMTP id n46KPRXb022333 for ; Wed, 6 May 2009 13:25:27 -0700 Received: by qw-out-1920.google.com with SMTP id 4so239204qwk.8 for ; Wed, 06 May 2009 13:25:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.211.7 with SMTP id j7mr643059wfg.337.1241641526918; Wed, 06 May 2009 13:25:26 -0700 (PDT) In-Reply-To: <20090506190227.GS10734@adacore.com> References: <20090501225121.1C38B84890@localhost> <20090506190227.GS10734@adacore.com> Date: Wed, 06 May 2009 20:25:00 -0000 Message-ID: Subject: Re: [RFA] rename find_thread_pid to find_thread_ptid From: Doug Evans To: Joel Brobecker Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00136.txt.bz2 On Wed, May 6, 2009 at 12:02 PM, Joel Brobecker wrote: >> Anyone mind a global renaming of find_thread_pid to find_thread_ptid? > > I don't mind the renaming, but if we're going to rename it, what do > people thing about "find_thread_from_ptid". I always get confused by > the function name because it makes me think that the function returns > the pid/ptid instead of returning the thread from the ptid... > > That's just a suggestion and I don't want to start another bikeshed > discussion. The name you suggest is already better than the old name, > so I'm not objecting to your initial suggestion. I don't mind that renaming either, I prefer it too. But if one goes down that path then there's more than just find_thread_ptid to rename, so I left that for another day. Perhaps more work, but with the right tools it's rather trivial, so I went with consistency with what's there today and just fixed the pid->ptid bug.