Re: System V IPC for psim try #2

[Doug Evans <dje@google.com>]

On Fri, Nov 14, 2008 at 8:03 AM, Joel Sherrill
<joel.sherrill@oarcorp.com> wrote:
> Hi,
>
> I think I have taken Doug's comments into account
> with this revised version of the patch.  Hopefully
> it is ready to commit now.
>
> Comments appreciated.  Thanks.
>
> 2008-11-14  Joel Sherrill <joel.sherrill@oarcorp.com>
>
>       * Makefile.in, configure.ac, debug.c, debug.h, hw_sem.c, hw_shm.c:
>       Add support for System V shared memory and semaphores to PSIM where
>       available on the host.  Shared memory can be mapped into the
>       simulated processor's address space and protected using a semaphore.
>       * configure: Regenerated.

Hi.  Thanks for the making the changes.

nit: I think the convention is one *-line per file, though I see
sim/ppc/ChangeLog doesn't follow that rule precisely.  I like your
original changelog entry better (fwiw).

2008-09-08 Joel Sherrill <joel.sherrill@oarcorp.com>

 * configure: Regenerated.
 * configure.ac: Add test for System V shared memory and semaphore.
 * debug.c, debug.h: Add trace support for new devices.
 * hw_sem.c, hw_shm.c: New files.
 * Makefile.in: Add hw_sem.c and hw_shm.c.

Regarding:

+if test "$ac_cv_has_union_semun" = "yes"; then
+  AC_CACHE_CHECK(whether System V semaphores are supported,
+  ac_cv_sysv_sem,
+  [
+  AC_TRY_RUN(
+  [

Apologies for not noting this before.  I see ppc/configure.ac already
uses AC_TRY_RUN, so it's ok with me.  The problem with AC_TRY_RUN is
that it doesn't work in cross compilation environments.  In this case
all that will happen is that the sim won't support these extra
features so no big deal (And apologies if all of this has already gone
through your mind ... :-))