From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7481 invoked by alias); 17 Nov 2008 07:04:26 -0000 Received: (qmail 7298 invoked by uid 22791); 17 Nov 2008 07:04:25 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 17 Nov 2008 07:03:29 +0000 Received: from spaceape11.eur.corp.google.com (spaceape11.eur.corp.google.com [172.28.16.145]) by smtp-out.google.com with ESMTP id mAH73Qsl024229 for ; Sun, 16 Nov 2008 23:03:27 -0800 Received: from rv-out-0506.google.com (rvbg37.prod.google.com [10.140.83.37]) by spaceape11.eur.corp.google.com with ESMTP id mAH73O49017956 for ; Sun, 16 Nov 2008 23:03:25 -0800 Received: by rv-out-0506.google.com with SMTP id g37so2380941rvb.33 for ; Sun, 16 Nov 2008 23:03:24 -0800 (PST) MIME-Version: 1.0 Received: by 10.141.50.11 with SMTP id c11mr2085871rvk.28.1226905404083; Sun, 16 Nov 2008 23:03:24 -0800 (PST) In-Reply-To: <491DA162.3030402@oarcorp.com> References: <491DA162.3030402@oarcorp.com> Date: Mon, 17 Nov 2008 20:31:00 -0000 Message-ID: Subject: Re: System V IPC for psim try #2 From: Doug Evans To: Joel Sherrill Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00430.txt.bz2 On Fri, Nov 14, 2008 at 8:03 AM, Joel Sherrill wrote: > Hi, > > I think I have taken Doug's comments into account > with this revised version of the patch. Hopefully > it is ready to commit now. > > Comments appreciated. Thanks. > > 2008-11-14 Joel Sherrill > > * Makefile.in, configure.ac, debug.c, debug.h, hw_sem.c, hw_shm.c: > Add support for System V shared memory and semaphores to PSIM where > available on the host. Shared memory can be mapped into the > simulated processor's address space and protected using a semaphore. > * configure: Regenerated. Hi. Thanks for the making the changes. nit: I think the convention is one *-line per file, though I see sim/ppc/ChangeLog doesn't follow that rule precisely. I like your original changelog entry better (fwiw). 2008-09-08 Joel Sherrill * configure: Regenerated. * configure.ac: Add test for System V shared memory and semaphore. * debug.c, debug.h: Add trace support for new devices. * hw_sem.c, hw_shm.c: New files. * Makefile.in: Add hw_sem.c and hw_shm.c. Regarding: +if test "$ac_cv_has_union_semun" = "yes"; then + AC_CACHE_CHECK(whether System V semaphores are supported, + ac_cv_sysv_sem, + [ + AC_TRY_RUN( + [ Apologies for not noting this before. I see ppc/configure.ac already uses AC_TRY_RUN, so it's ok with me. The problem with AC_TRY_RUN is that it doesn't work in cross compilation environments. In this case all that will happen is that the sim won't support these extra features so no big deal (And apologies if all of this has already gone through your mind ... :-))