From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 5/7] [gdb/testsuite] Fix Term::_csi_m with no args
Date: Wed, 23 Jul 2025 22:34:04 +0200 [thread overview]
Message-ID: <e32d6ffb-d08b-49b5-926b-76093a6b8e28@suse.de> (raw)
In-Reply-To: <87cy9qu5dd.fsf@tromey.com>
On 7/23/25 20:30, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>
> Tom> When calling Term::_csi_m with no args, default behaviour needs to be applied,
> Tom> which is equivalent to "Term::_csi_m 0" [1].
>
> Tom> However, while "Term::_csi_m 0" works, as well as 'Term::_csi_m ""', calling
> Tom> Term::_csi_m with no args has no effect.
>
> Tom> Fix this by implementing the default behaviour in Term::_csi_m.
>
> Ok.
> Approved-By: Tom Tromey <tom@tromey.com>
>
> Tom> + set args { 0 }
>
> The spaces seem mildly unusual since I don't think they'd be in a "real"
> argument of just "0".
Hi Tom,
thanks for the review(s).
Yes, sorry about that. I keep getting tripped up about the tcl string
vs list confusion.
I added the spaces for readability, which doesn't matter when regarding
args as a list, but it does when treating it as a string.
Fixed by used [list 0] instead.
Thanks,
- Tom
next prev parent reply other threads:[~2025-07-23 20:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 13:01 [PATCH 0/7] [gdb/testsuite] Fix TUI tests for freebsd Tom de Vries
2025-07-18 13:01 ` [PATCH 1/7] [gdb/testsuite] Fix Cursor Horizontal Absolute clipping Tom de Vries
2025-07-18 13:01 ` [PATCH 2/7] [gdb/testsuite] Handle Horizontal Position Absolute in tuiterm Tom de Vries
2025-07-18 13:01 ` [PATCH 3/7] [gdb/testsuite] Log on return in Term::_log_cur Tom de Vries
2025-07-23 18:28 ` Tom Tromey
2025-07-24 7:18 ` Tom de Vries
2025-07-18 13:01 ` [PATCH 4/7] [gdb/testsuite] Handle auto_left_margin in tuiterm Tom de Vries
2025-07-23 18:36 ` Tom Tromey
2025-07-18 13:01 ` [PATCH 5/7] [gdb/testsuite] Fix Term::_csi_m with no args Tom de Vries
2025-07-23 18:30 ` Tom Tromey
2025-07-23 20:34 ` Tom de Vries [this message]
2025-07-24 1:17 ` Tom Tromey
2025-07-18 13:01 ` [PATCH 6/7] [gdb/testsuite] Use TERM=ansiw in tuiterm for bsd Tom de Vries
2025-07-23 18:34 ` Tom Tromey
2025-07-24 9:47 ` Tom de Vries
2025-07-18 13:01 ` [PATCH 7/7] [gdb/testsuite] Add Term::get_string_with_attrs in tuiterm Tom de Vries
2025-07-23 18:36 ` Tom Tromey
2025-07-24 10:07 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e32d6ffb-d08b-49b5-926b-76093a6b8e28@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox