From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id vDbrK1NHgWgO1joAWB0awg (envelope-from ) for ; Wed, 23 Jul 2025 16:34:27 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=iBxW8v+v; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=TDA9kL/d; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=iBxW8v+v; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=TDA9kL/d; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9D8AF1E102; Wed, 23 Jul 2025 16:34:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AF8B51E089 for ; Wed, 23 Jul 2025 16:34:26 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 20AF73858C48 for ; Wed, 23 Jul 2025 20:34:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 20AF73858C48 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=iBxW8v+v; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=TDA9kL/d; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=iBxW8v+v; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=TDA9kL/d Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 0C2323858D33 for ; Wed, 23 Jul 2025 20:33:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0C2323858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0C2323858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1753302835; cv=none; b=rmrmtzBoV7MGZlawBcRbSwTSTkp7xNByFaVuhA20Dpiam5k56Vng2FwmfdNF5rtKUtYqyk+EWBdgyv2B5eLVl1unPBvXPfhzRxFZn0qFQUHqx4r6PdUQS5DAUCgToLT2qkpmKA5ATYy6pKMACIX9QakQE/TYWDbAcrmU2KQn0VE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1753302835; c=relaxed/simple; bh=yS/OgrFdOlQFSXEgtaSYVrDA6Xjlp7Sy864i6si9KNw=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=Fgq9BkdAMsNgghxDEKgNUO41qoEnAjhT9djIsvY8oHDWCGQBbQMoXHDqdx9t/ySDnuYb/QT3udgbRdJu/j6CDbCMyf5veZya04YXt4OZD4ihOYqWIEqSkiUfJ3ojihv5slzTDxEGpeZWow95wa1Zzj3DcJoqTiVmOHhlhGVtUPk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0C2323858D33 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0BE161F806; Wed, 23 Jul 2025 20:33:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1753302832; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eFzSFeux9vwnjOqcT62YjDlNtuZPEtEWgDKSV3ZQbxQ=; b=iBxW8v+vAEA5RwMsp+zZhP7MQUpGzTQx6wkCPJgRe4fadPnPYEqu3nkp5frFaRJYZKQIod yS7JAGwlPWI83AP9LQT3IpwXbs2fp4jmq21rO91Qdz5Kc5e/8DO4f1xuyPefM10fU0fQEV QFXvwsyu8qGdnqam9CicsvzuMXYkLws= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1753302832; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eFzSFeux9vwnjOqcT62YjDlNtuZPEtEWgDKSV3ZQbxQ=; b=TDA9kL/dpZ5qr8qxKvYb50E8tl6mWaPKJ1bKIPWrZTI5UwpnJ63gTNpUb6PwDvBXWp379/ e9uC5YUSS9Lt0DCA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=iBxW8v+v; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="TDA9kL/d" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1753302832; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eFzSFeux9vwnjOqcT62YjDlNtuZPEtEWgDKSV3ZQbxQ=; b=iBxW8v+vAEA5RwMsp+zZhP7MQUpGzTQx6wkCPJgRe4fadPnPYEqu3nkp5frFaRJYZKQIod yS7JAGwlPWI83AP9LQT3IpwXbs2fp4jmq21rO91Qdz5Kc5e/8DO4f1xuyPefM10fU0fQEV QFXvwsyu8qGdnqam9CicsvzuMXYkLws= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1753302832; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eFzSFeux9vwnjOqcT62YjDlNtuZPEtEWgDKSV3ZQbxQ=; b=TDA9kL/dpZ5qr8qxKvYb50E8tl6mWaPKJ1bKIPWrZTI5UwpnJ63gTNpUb6PwDvBXWp379/ e9uC5YUSS9Lt0DCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DD68613ABE; Wed, 23 Jul 2025 20:33:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 3CyhNC9HgWiJFAAAD6G6ig (envelope-from ); Wed, 23 Jul 2025 20:33:51 +0000 Message-ID: Date: Wed, 23 Jul 2025 22:34:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/7] [gdb/testsuite] Fix Term::_csi_m with no args To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20250718130153.24989-1-tdevries@suse.de> <20250718130153.24989-6-tdevries@suse.de> <87cy9qu5dd.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87cy9qu5dd.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:mid,suse.de:dkim,suse.de:email]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Queue-Id: 0BE161F806 X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 7/23/25 20:30, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> When calling Term::_csi_m with no args, default behaviour needs to be applied, > Tom> which is equivalent to "Term::_csi_m 0" [1]. > > Tom> However, while "Term::_csi_m 0" works, as well as 'Term::_csi_m ""', calling > Tom> Term::_csi_m with no args has no effect. > > Tom> Fix this by implementing the default behaviour in Term::_csi_m. > > Ok. > Approved-By: Tom Tromey > > Tom> + set args { 0 } > > The spaces seem mildly unusual since I don't think they'd be in a "real" > argument of just "0". Hi Tom, thanks for the review(s). Yes, sorry about that. I keep getting tripped up about the tcl string vs list confusion. I added the spaces for readability, which doesn't matter when regarding args as a list, but it does when treating it as a string. Fixed by used [list 0] instead. Thanks, - Tom