Re: [PATCH v3 2/2] gdb: add stat64 and fstat64 to the F-packet file-i/o protocol

[Ulrich Weigand <Ulrich.Weigand@de.ibm.com>]

Abhay Kandpal <abhay@linux.ibm.com> wrote:

 
>There is a second mismatch as well. For a regular file, the fstat
>handler never sets fst_dev, so the host's real st_dev is passed
>through rather than the documented 0. Today only stat matches
>the documentation:
>
>stat, file:        documented 0, sends 0
>fstat, console:    documented 1, sends 0
>fstat, file:       documented 0, sends the host's st_dev

Ah, right.  That's even more confusing.

>My preference would be to fix the code to match the documentation,
>since the 2015 change looks accidental. I'd do that as a separate
>patch, so it doesn't depend on the stat64 series.

This makes sense to me, yes.

Thanks,
Ulrich