From: Abhay Kandpal <abhay@linux.ibm.com>
To: gdb-patches@sourceware.org
Cc: aburgess@redhat.com, Ulrich.Weigand@de.ibm.com, eliz@gnu.org,
cel@linux.ibm.com, abhay.k@ibm.com,
Abhay Kandpal <abhay@linux.ibm.com>
Subject: [PATCH v3 0/2] Widen the stat fields in the remote protocol
Date: Wed, 14 Oct 2026 04:21:37 -0500 [thread overview]
Message-ID: <20261014092139.399322-1-abhay@linux.ibm.com> (raw)
The struct fio_stat used by the remote protocol declares st_dev,
st_ino, st_nlink, st_rdev and the three timestamps as 4 bytes, so
those values are truncated on a 64-bit host. On a large xfs
filesystem this makes gdb.server/fileio-packets.exp fail. PR 34567.
The struct is used in two directions, and the two need different
fixes:
1/2 vFile packets (GDB asking gdbserver): a new 'stat64'
qSupported feature selects a wide struct. This is v2,
rebased, with only the commit message adjusted.
2/2 F-packet file-i/o calls (the target asking GDB): new
Fstat64 and Ffstat64 calls write the wide struct. An older
GDB replies ENOSYS, so a target can fall back to Fstat.
Changes in v3:
- Add 2/2, covering the F-packet direction as Andrew asked.
Thanks to Ulrich for suggesting the new-syscall approach.
- 1/2 is unchanged apart from the commit message.
Abhay Kandpal (2):
gdbserver: widen the stat fields returned by the vFile packets
gdb: add stat64 and fstat64 to the F-packet file-i/o protocol
gdb/NEWS | 22 +++++
gdb/doc/gdb.texinfo | 96 +++++++++++++++++++
gdb/remote-fileio.c | 102 +++++++++++++++++---
gdb/remote-fileio.h | 4 +
gdb/remote.c | 36 +++++--
gdb/testsuite/gdb.server/fileio-packets.py | 59 +++++++-----
gdbserver/hostio.cc | 106 +++++++++++++++------
gdbserver/server.cc | 4 +-
gdbserver/server.h | 5 +
gdbsupport/fileio.cc | 70 ++++++++++++++
gdbsupport/fileio.h | 54 ++++++++++-
11 files changed, 480 insertions(+), 78 deletions(-)
--
2.52.0
next reply other threads:[~2026-10-14 9:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 9:21 Abhay Kandpal [this message]
2026-10-14 9:21 ` [PATCH v3 1/2] gdbserver: widen the stat fields returned by the vFile packets Abhay Kandpal
2026-10-27 17:27 ` Ulrich Weigand
2026-10-27 22:16 ` Andrew Burgess
2026-10-14 9:21 ` [PATCH v3 2/2] gdb: add stat64 and fstat64 to the F-packet file-i/o protocol Abhay Kandpal
2026-10-14 11:47 ` Eli Zaretskii
2026-10-27 17:47 ` Ulrich Weigand
2026-10-28 10:42 ` Abhay Kandpal
2026-10-28 14:19 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261014092139.399322-1-abhay@linux.ibm.com \
--to=abhay@linux.ibm.com \
--cc=Ulrich.Weigand@de.ibm.com \
--cc=abhay.k@ibm.com \
--cc=aburgess@redhat.com \
--cc=cel@linux.ibm.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox