From: Pedro Alves <palves@redhat.com>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/testsuite] Make gdb_test message unique in multi-term-settings.exp
Date: Thu, 22 Aug 2019 14:46:00 -0000 [thread overview]
Message-ID: <e26cfaaa-d3ad-d6cd-0ca9-32726bee93a2@redhat.com> (raw)
In-Reply-To: <20190822142148.GA5361@delia>
On 8/22/19 3:21 PM, Tom de Vries wrote:
> Hi,
>
> This racy fail message, reported in PR24929:
> ...
> FAIL: gdb.multi/multi-term-settings.exp: inf1_how=attach: inf2_how=attach: \
> stop with control-c
> ...
> does not make clear which gdb_test fails here:
> ...
> if {$expect_ttou} {
> gdb_test "" "Quit" "stop with control-c"
> } else {
> gdb_test "" "received signal SIGINT.*" "stop with control-c"
> }
> ...
>
> Fix this by making the gdb_test message argument unique.
Pedantically, adding " (foo)" is not considered to make a message
unique.
" (foo)" is just informative (and likewise used in other parts of
the testcase in that fashion).
The message is already unique given the "inf1_how=attach: inf2_how=attach:"
prefix.
>
> Tested on x86_64-linux.
>
> OK for trunk?
OK.
Thanks,
Pedro Alves
prev parent reply other threads:[~2019-08-22 14:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 14:21 Tom de Vries
2019-08-22 14:46 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e26cfaaa-d3ad-d6cd-0ca9-32726bee93a2@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox