From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64460 invoked by alias); 22 Aug 2019 14:46:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 64427 invoked by uid 89); 22 Aug 2019 14:46:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:889 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Aug 2019 14:46:05 +0000 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 98ECB5FD4D for ; Thu, 22 Aug 2019 14:46:03 +0000 (UTC) Received: by mail-wm1-f72.google.com with SMTP id d65so3042959wmd.3 for ; Thu, 22 Aug 2019 07:46:03 -0700 (PDT) Received: from ?IPv6:2001:8a0:f913:f700:4c97:6d52:2cea:997b? ([2001:8a0:f913:f700:4c97:6d52:2cea:997b]) by smtp.gmail.com with ESMTPSA id 2sm34519270wrg.83.2019.08.22.07.46.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Aug 2019 07:46:01 -0700 (PDT) Subject: Re: [PATCH][gdb/testsuite] Make gdb_test message unique in multi-term-settings.exp To: Tom de Vries , gdb-patches@sourceware.org References: <20190822142148.GA5361@delia> From: Pedro Alves Message-ID: Date: Thu, 22 Aug 2019 14:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190822142148.GA5361@delia> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-08/txt/msg00530.txt.bz2 On 8/22/19 3:21 PM, Tom de Vries wrote: > Hi, > > This racy fail message, reported in PR24929: > ... > FAIL: gdb.multi/multi-term-settings.exp: inf1_how=attach: inf2_how=attach: \ > stop with control-c > ... > does not make clear which gdb_test fails here: > ... > if {$expect_ttou} { > gdb_test "" "Quit" "stop with control-c" > } else { > gdb_test "" "received signal SIGINT.*" "stop with control-c" > } > ... > > Fix this by making the gdb_test message argument unique. Pedantically, adding " (foo)" is not considered to make a message unique. " (foo)" is just informative (and likewise used in other parts of the testcase in that fashion). The message is already unique given the "inf1_how=attach: inf2_how=attach:" prefix. > > Tested on x86_64-linux. > > OK for trunk? OK. Thanks, Pedro Alves