Re: [PATCH] Implement nbsd_nat_target::thread_alive

[Kamil Rytarowski <n54@gmx.com>]

On 25.03.2020 22:08, Simon Marchi wrote:
> On 2020-03-25 5:01 p.m., Kamil Rytarowski wrote:
>> On 25.03.2020 21:42, John Baldwin wrote:
>>> Given that you have nearly identical code both here and in the thread_name
>>> method in your other patch, perhaps it makes sense to have a single
>>> "gdb::unique_xmalloc_ptr <struct kinfo_lwp> fetch_kinfo_lwp(ptid_t ptid)"
>>> helper function that the other routines could share?  Perhaps instead of
>>> just returning the pointer to the array of structures it could take a lamda
>>> function that is invoked on the matching 'kl' instance with the correct lwp?
>>>
>>
>> I can do it. I will submit these two patches in one go. I will also add
>> a third similar function to list threads within a process.
>>
>> Normally, I would go for PT_LWPSTATUS, but it is available since NetBSD
>>> 10 and for the time being sysctl(3) is more portable.
>
> And let me mention the same thing I've told John :).  Please add a meaningful
> commit message, explaining why you do this change.  It's easy to see _what_
> it does, but not _why_ you needed to do it.  Does it enable some feature, does
> it fix some test case, something else?  What impact does it have?
>
> Simon
>

Done in [PATCH v2] Implement basic threading support in the NetBSD target.

Please review.