From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by sourceware.org (Postfix) with ESMTPS id 6F600385E006 for ; Thu, 26 Mar 2020 04:02:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6F600385E006 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gmx.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=n54@gmx.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1585195308; bh=k3Gi3bQj6aLhhGw/yp9mGcNeKXj7JpV1JUrdmhGPUbc=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=lxeqnlX7w6w46ckvqO7t8mQdvogqV+l1ocEKN0eowf8eTCs+jNWQFaKhA8P5yblcc OSBtRssaAYc02uH1OT1+Png+b7ndky+heug1f0GmkeFTAIqr4zYizL+MwPUZC/rJAD yBGvLOMPgNjgNUg3Jz+t7H+DnNHr9VsraVWw9EWs= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.241] ([89.79.191.25]) by mail.gmx.com (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1Mi2O1-1jmXnh2afZ-00e8zP; Thu, 26 Mar 2020 05:01:48 +0100 Subject: Re: [PATCH] Implement nbsd_nat_target::thread_alive To: Simon Marchi , John Baldwin , gdb-patches@sourceware.org References: <20200325193646.29248-1-n54@gmx.com> <64888cf7-8aff-20df-db9e-72b911eebc99@FreeBSD.org> <3349e5b4-d936-4597-7afe-4cef27216c93@gmx.com> From: Kamil Rytarowski Autocrypt: addr=n54@gmx.com; prefer-encrypt=mutual; keydata= mQINBFVwUF8BEADHmOg7PFLIcSDdMx5HNDYr8MY2ExGfUTrKwPndbt3peaa5lHsK+UGoPG48 KiWkhEaMmjaXHFa7XgVpJHhFmNoJXfPgjI/sOKTMCPQ5DEHEHTibC4mta7IBAk+rmnaOF0k8 bxHfP8Qbls66wvicrAfTRXn/1ReeNc3NP4Sq39PoVHkfQTlnQiD4eAqBdq61B7DhzjhbKAZ4 RsNtLfB6eOv9qvmblUzs50ChYewM9hvn+c7MdDH+x2UXoSDhkBDkKcJGkX91evos8s9AuoEd D32X5e+bmdUGe8Cr3cAZJ8IEXR6F9828/kxzPliMsCWVRx1Fr28baCJOUGgFPNr3ips78m9+ Iw8PdQ101jU0dvucDFxw/1SCGYEZzV+O/237oRPuLCiDX5nhQoxf6dn9ukQleLBMNy2BLI4H g342NhF21HLA+KlyLOHaMKQCKzlal+zVNZTRTCh/ikMhsxWQjBfnqTDbMj85DnWwtump27SI qhPjUnS0a6MKoS/A+hbi64k5zztkvloELfCSrX7NyBTT0jgF2IGFIxZMrKCtQ9StcGMCV9MX tjcBy6fj7QMontEaIDRJEMjg8UIGw1B687OhalOv1ISia4xOWvpYAM6ipgqh6tBQmFzasL9P h1RtcVdFpFbhwVlr1Bly8c25gBNQHL5GUjLMn45LlQz50OzrkwARAQABtCdLYW1pbCBSeXRh cm93c2tpIChOZXRCU0QpIDxuNTRAZ214LmNvbT6JAjwEEwEIACYCGyMHCwkIBwMCAQYVCAIJ CgsEFgIDAQIeAQIXgAUCVbKGFwIZAQAKCRBLswjpsC52bIVpD/9i8npieI91xMIVvAHIUMeo cQO0IrNb+b/PuTj2qNemdwU7dhVJ7tVU5O1H2hI2M4rHGzjzDTxYzdxka0+A8CVEuvFdf6sF lXlXF0wM7rC6MoaB0QLAKxkZB5OtCILxLx7Bl2Y4cTPMU9v+qSL6yrdmhxogkufa4d6O9Zl/ FCWO2kH/BphKOiDtbyvdo2WULSLWP2IXN+0rCpNL4wbTfYLgV9JtMf8f0naGsdy7BFuDWsIE vtHh8dkQZP7dz6Qy67kx8negZaehSEgXwiae0HwQIn3xTQrFmBDALDsCgXuLWPTvglSkqTak uG+8X5fyTy0cU10TNKsU+rFBO+/xsUoIQOGrARwfWOIfJNPelzh/qigSnyNQNH8u5vFRPg9n fqB/AcvvAvtOYOo8EN9Ofx11gNj397NXc5HBQTrX6k5GNAeBWE3Ng1uO6scIwAS7qGnqGezU ABmQKLN37gmJiiGwhQAnSE6HILLBC5Z2b0S2rQsPKg8WgUmPa1YIcDkDtNB/LJcDsdU4Fm+r U2ksKU7tGD2ZfBt8H2nqfPKKeB+Uv/TBigjRvx/m70vjhqVxwCZA9Fqr9vkQkZroNfqP+3dp Z5V5fjmxO5abE2+IikSvFagwMtgx56i8Yrr2BzE8P5/S4cKq1kgyQoF+lVGDKRkUKCv1i4Fo aftnSxN8jTFZDbkCDQRVcFBfARAAutbzb8wAHGL5FPPWKErQ3Bsrp9RDTVqRzp7kBMOtd/14 MrOsWWyiml4XnvBYsJuhZWomFoeulcOXAPoTJ2vTw6erWYtdOiZymfQ3GMWpxzgkOVeNjsFF 9AQ38FCMKmIDs9dgn+KXSIXlZA34khKLd163SN5U/KHfYlnnocec31u+7rVa1hlF5DBSSpoi s8cs41foBYC5NsB/i+yqGIlfzHy7pC2u5kyQCuJotLH4y0rT5X+YBC7z7cqKChtILNDGw0ht qps29fwOGBE/FWmu8CbpSHj8pvg7uUyQcKbZbNChBfWtOJKdjnNs5VHf2ec95SwYmWl6Xz66 G892HY4ODtvl05/kh0qtdJd2oI4gJBsBx/N1585/3JYN4k78GIHTnML3xJydRRs9wwM3AXf/ iDGrMyY7qHQVXJLdO5nPe7LHg48vryCMkBnTMw5iNFPVCu5w1BaZyHxuS2HvpsgUtQoBa2QE P1jYNI+2qgoiIG4VQDhYtrD0WJaYdi/C2UVDxRy07dt73SV3RQ7ijOiUrz4g3/deFKY16/1k sE+N5Sc5Tjt84ChjO3nJRbHrQxd6dCOElR70e3R2yAuSB4m7LJpO20IB9CtWhlF/0AtfL91W O8GGGqLWB0Z04hmwRs/l8T4WWIlykLshbunWN6jsP1Y27FeilTZ+Pc9mYOEUFfEAEQEAAYkC HwQYAQgACQUCVXBQXwIbDAAKCRBLswjpsC52bPayD/9jE8mdNudrudSxbDB2vf8pU8r5flCq vIkfOdpZGV/Wx/Zx+HFHHp+b2aNBGSNyFTnph1Ku9bvg06vD0o+b7SdA1vrBgRG41t0OCIyf vejz65Xpin2EtCllcBM8zUCxHo43blON8fNw70P1Ec0loBp4TAal1MiXbB8kxRTRcEPVO9YF 9NPsFxycoWl0ZSvu4ESrQlrjRbVv+W0Fy/XqcQwEtDziFQHQXNRbTy8INPD49CsB7BkKRK+f 1vMmw7SxfsyEhyCgo9ZWfHb/+w9T5h+UhF87L/m287z7W+s4aCAPBzjbIWhtngGJJwIgiWdI I9J6YJLcHLvVZLw7xzA/flcjc0VfzOgJOJw3hBukHnEz7/CKgnABwyNu52P+PQbxVTiTjMKm 06eV732u9ZLD9ZgEazfmyGDHzsuzoXwsRnmcnbwYYAiynS+vfGl5oMtMa5qzsPhlzuvRlXHm zr8VjF8c9RThvyZyyHtWYAqNmBecMvM0whigjMeoAMJ5LtpyZgxjbHj1XnVdNBZgfJkOzsc/ twffi7RYphRx0d9z5UZ1Yl5Rvl05vTaJ7YhhNC7xuE8yGOQmDUsPDwWqO/eXUDErJjCOBR5b 0yILqRPYNT0Fj/th9gtEbZy1Gp0TVBkZM3tfjDRu43Pn6iSKObO/j0rNuq1LwN/EMxDifeZO 4XSbcg== Message-ID: Date: Thu, 26 Mar 2020 05:00:38 +0100 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:oNF9xe2nx42Y3TWAQS5RPo9Ii4MCya3uWUbs7FtEQmGPSLiHnnl qBIW/N2SVo2am80oQnugCKXo2ME5jNbLdU3WWBlOko6e2gRibW0s38N5GZmOjoNJUDJIcoR Ec37dNfK+M7QRz0+81qT7jBNN3aSfoq7XaX5dpl8V18Rxi5adQ0pqKgdkP5esuKuZMh5w7l KAU6Sirtze4W+1DfhQsZA== X-UI-Out-Filterresults: notjunk:1;V03:K0:+gdOzGdAH5I=:EbFK5QP1lpOqTeAtdgKkfw 6dY6keUwP31CvhEwvCmjJ1HeYTsdjPLZ+nTXTG85bwA0Jv2QEEmChdxrhwMl7sYyKCh+oyIyU DsqKUxMVUggK3dx/WsyBbHwHK8navCd1UYxsEgLFusqJVN2O5d+47N2MYP6Lhz6e6h3BynElx LjePCmkPyIB5cgGxfFzoRNgEVo4/cCLT+6M/Z9e1ES7lXM8gDnUc0mDFMFwz7V76niFrrizsH v4EdhggGp38q2/2qfd23BrrJhA2VWg5VhXWJ2My71HZbfrUjIU68MQS3h4cGoWfC1/fZ7y5xa q//U0ofME/AihDIMyoGksU2ezmPwW1hMYcmm7fV81dkUH9rsths9PPQWpAoVhrOFdPJsxCHru mIto6txcE1MMHgZBOb8xUagUVog9yjXQAYtbUz4J9mxyqqg1o6hI3jnvs442wef3T0Cp2+Gyv 7+iSm10VRyMtmzRJI6RHTe277qXJkrhPjZ9PiYZijpIi483K+pHVHuB0chT+xd/uvX2gqSuOL EI3YgZCuIYLSkX13FnYi6O8/pimmTCoxjltK3PEuzX+4w8XoyohDn/LgEDPvxNHA8uNfmMCO8 OWERpAxoYJR8tjgw5l+p42rgcjrnTH/ILDngVrpJ7DwT2C2wo1BUBP1WbEOXILWb5NEDDZZbz yW3cdtP9xp78lGHQTNGY4Uw0/6PjSgLudWxOuCs86IcxNyIJDyxTOPOiryOu0d7reOpCCJtDZ leFLkKvICgYZJN7bKX3mUjYqH6QyOK0KZNQuGwqokYRDW8Ww5CDvssWsXAMHhlchfU+JRibi0 5mI5k3chtxanLjktHdigXD6d0nCEjTlUSIkRQStiZ2OYYO3tnG3MQaoU7c3UhSFmSSIxlnqyY s6aV16TDio45ABdEJERngyfzQVfl6TKaYgEIV3IO4ERu/qOwy4dAqo3iUugBfQZY9tDiTiEsW rgJpOx0nXfuX3zpcQnuAAbduPvTleeMUkN7D9nnK2dIwVkxXDpY/HocK3akuy6ozpGc4XHiJ3 EvBmNH8GnO7WcGb2Z6irCERVDtXuh7Xl88ePdEZQrJvPaBlEmII/bBKLqrcaS/ygOXGrobUyM SuAAQA3+z221bRx6MdzHbXSLvzGMI1fvBldV6AC0L0MWgOb2RG7WCNQxsIHuhWFfged8dSQJA 3tYNqB78/rhXFhMP1q0ozS2WJNkOzH5psJEUjCInDRVfsiEXi0FC7WFxABmk9s2q65QUU= X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Mar 2020 04:02:23 -0000 On 25.03.2020 22:08, Simon Marchi wrote: > On 2020-03-25 5:01 p.m., Kamil Rytarowski wrote: >> On 25.03.2020 21:42, John Baldwin wrote: >>> Given that you have nearly identical code both here and in the thread_= name >>> method in your other patch, perhaps it makes sense to have a single >>> "gdb::unique_xmalloc_ptr fetch_kinfo_lwp(ptid_t pti= d)" >>> helper function that the other routines could share? Perhaps instead = of >>> just returning the pointer to the array of structures it could take a = lamda >>> function that is invoked on the matching 'kl' instance with the correc= t lwp? >>> >> >> I can do it. I will submit these two patches in one go. I will also add >> a third similar function to list threads within a process. >> >> Normally, I would go for PT_LWPSTATUS, but it is available since NetBSD >>> 10 and for the time being sysctl(3) is more portable. > > And let me mention the same thing I've told John :). Please add a meani= ngful > commit message, explaining why you do this change. It's easy to see _wh= at_ > it does, but not _why_ you needed to do it. Does it enable some feature= , does > it fix some test case, something else? What impact does it have? > > Simon > Done in [PATCH v2] Implement basic threading support in the NetBSD target. Please review.