Re: [RFA 2/3] Constify language_enum

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2017-09-11 02:33, Tom Tromey wrote:
> Change language_enum to take a const argument.
> 
> ChangeLog
> 2017-09-10  Tom Tromey  <tom@tromey.com>
> 
> 	* language.h (language_enum): Make argument const.
> 	* language.c (language_enum): Make argument const.
> ---
>  gdb/ChangeLog  | 5 +++++
>  gdb/language.c | 2 +-
>  gdb/language.h | 2 +-
>  3 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index a906d50..4c2a924 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,5 +1,10 @@
>  2017-09-10  Tom Tromey  <tom@tromey.com>
> 
> +	* language.h (language_enum): Make argument const.
> +	* language.c (language_enum): Make argument const.
> +
> +2017-09-10  Tom Tromey  <tom@tromey.com>
> +
>  	* common/common-utils.h (skip_to_space): Remove macro, redeclare
>  	as function.
>  	(skip_to_space): Rename from skip_to_space_const.
> diff --git a/gdb/language.c b/gdb/language.c
> index 7f870d8..e92c3c5 100644
> --- a/gdb/language.c
> +++ b/gdb/language.c
> @@ -478,7 +478,7 @@ range_error (const char *string,...)
>  /* Return the language enum for a given language string.  */
> 
>  enum language
> -language_enum (char *str)
> +language_enum (const char *str)
>  {
>    for (const auto &lang : languages)
>      if (strcmp (lang->la_name, str) == 0)
> diff --git a/gdb/language.h b/gdb/language.h
> index 57e48bd..d4ca900 100644
> --- a/gdb/language.h
> +++ b/gdb/language.h
> @@ -562,7 +562,7 @@ extern int value_true (struct value *);
> 
>  /* Misc:  The string representing a particular enum language.  */
> 
> -extern enum language language_enum (char *str);
> +extern enum language language_enum (const char *str);
> 
>  extern const struct language_defn *language_def (enum language);

Ok.