From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102178 invoked by alias); 11 Sep 2017 19:17:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 102085 invoked by uid 89); 11 Sep 2017 19:17:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1747 X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 11 Sep 2017 19:17:20 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v8BJHDlh001777 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 11 Sep 2017 15:17:18 -0400 Received: by simark.ca (Postfix, from userid 112) id 9F3991ECB9; Mon, 11 Sep 2017 15:17:13 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 854C51EA19; Mon, 11 Sep 2017 15:17:03 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 11 Sep 2017 19:17:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 2/3] Constify language_enum In-Reply-To: <20170911003325.3765-3-tom@tromey.com> References: <20170911003325.3765-1-tom@tromey.com> <20170911003325.3765-3-tom@tromey.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 11 Sep 2017 19:17:13 +0000 X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00310.txt.bz2 On 2017-09-11 02:33, Tom Tromey wrote: > Change language_enum to take a const argument. > > ChangeLog > 2017-09-10 Tom Tromey > > * language.h (language_enum): Make argument const. > * language.c (language_enum): Make argument const. > --- > gdb/ChangeLog | 5 +++++ > gdb/language.c | 2 +- > gdb/language.h | 2 +- > 3 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index a906d50..4c2a924 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,5 +1,10 @@ > 2017-09-10 Tom Tromey > > + * language.h (language_enum): Make argument const. > + * language.c (language_enum): Make argument const. > + > +2017-09-10 Tom Tromey > + > * common/common-utils.h (skip_to_space): Remove macro, redeclare > as function. > (skip_to_space): Rename from skip_to_space_const. > diff --git a/gdb/language.c b/gdb/language.c > index 7f870d8..e92c3c5 100644 > --- a/gdb/language.c > +++ b/gdb/language.c > @@ -478,7 +478,7 @@ range_error (const char *string,...) > /* Return the language enum for a given language string. */ > > enum language > -language_enum (char *str) > +language_enum (const char *str) > { > for (const auto &lang : languages) > if (strcmp (lang->la_name, str) == 0) > diff --git a/gdb/language.h b/gdb/language.h > index 57e48bd..d4ca900 100644 > --- a/gdb/language.h > +++ b/gdb/language.h > @@ -562,7 +562,7 @@ extern int value_true (struct value *); > > /* Misc: The string representing a particular enum language. */ > > -extern enum language language_enum (char *str); > +extern enum language language_enum (const char *str); > > extern const struct language_defn *language_def (enum language); Ok.