From: Simon Marchi <simon.marchi@polymtl.ca>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Move "tee" building down to interpreter::set_logging_proc
Date: Thu, 02 Feb 2017 15:17:00 -0000 [thread overview]
Message-ID: <e08d9ebe40cbb7f14861a46cad993501@polymtl.ca> (raw)
In-Reply-To: <1486045694-22866-1-git-send-email-palves@redhat.com>
On 2017-02-02 09:28, Pedro Alves wrote:
> @@ -109,13 +109,13 @@ extern int current_interp_named_p (const char
> *name);
>
> /* Call this function to give the current interpreter an opportunity
> to do any special handling of streams when logging is enabled or
> - disabled. START_LOG is 1 when logging is starting, 0 when it ends,
> - and OUT is the stream for the log file; it will be NULL when
> - logging is ending. LOGFILE is non-NULL if the output streams
> + disabled. START_LOG is true when logging is starting, false when
START_LOG is not there anymore. From what I understand, it's replaced
with LOGFILE being null or not?
Otherwise, LGTM.
next prev parent reply other threads:[~2017-02-02 15:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 14:28 Pedro Alves
2017-02-02 15:17 ` Simon Marchi [this message]
2017-02-02 17:39 ` Pedro Alves
2017-02-02 17:45 ` Simon Marchi
2017-02-02 18:04 ` Pedro Alves
2017-02-02 20:42 ` Simon Marchi
2017-02-02 22:12 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e08d9ebe40cbb7f14861a46cad993501@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox