From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-136693-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 116649 invoked by alias); 2 Feb 2017 15:17:43 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 116593 invoked by uid 89); 2 Feb 2017 15:17:42 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=opportunity
X-HELO: simark.ca
Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 02 Feb 2017 15:17:40 +0000
Received: by simark.ca (Postfix, from userid 33)	id 05D561E163; Thu,  2 Feb 2017 10:17:39 -0500 (EST)
To: Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH] Move "tee" building down to interpreter::set_logging_proc
X-PHP-Originating-Script: 33:rcube.php
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Content-Transfer-Encoding: 7bit
Date: Thu, 02 Feb 2017 15:17:00 -0000
From: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
In-Reply-To: <1486045694-22866-1-git-send-email-palves@redhat.com>
References: <1486045694-22866-1-git-send-email-palves@redhat.com>
Message-ID: <e08d9ebe40cbb7f14861a46cad993501@polymtl.ca>
X-Sender: simon.marchi@polymtl.ca
User-Agent: Roundcube Webmail/1.2.3
X-IsSubscribed: yes
X-SW-Source: 2017-02/txt/msg00070.txt.bz2

On 2017-02-02 09:28, Pedro Alves wrote:
> @@ -109,13 +109,13 @@ extern int current_interp_named_p (const char 
> *name);
> 
>  /* Call this function to give the current interpreter an opportunity
>     to do any special handling of streams when logging is enabled or
> -   disabled.  START_LOG is 1 when logging is starting, 0 when it ends,
> -   and OUT is the stream for the log file; it will be NULL when
> -   logging is ending.  LOGFILE is non-NULL if the output streams
> +   disabled.  START_LOG is true when logging is starting, false when

START_LOG is not there anymore.  From what I understand, it's replaced 
with LOGFILE being null or not?

Otherwise, LGTM.