From: Keith Seitz <keiths@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] Validate explicit locations with early termination
Date: Thu, 07 Dec 2017 23:41:00 -0000 [thread overview]
Message-ID: <dfb3b435-ec5e-7264-960e-42a7302682ad@redhat.com> (raw)
In-Reply-To: <003824fa-c538-3f02-729f-8bf8192d51a5@ericsson.com>
On 12/07/2017 01:33 PM, Simon Marchi wrote:
hese two commands should have elicited the same error message.
>>
>> gdb/ChangeLog:
>>
>> PR breakpoints/22569
>> * location.c (string_to_explicit_location): When terminating
>> parsing early, break out of enclosing loop instead of returning.
>>
>> gdb/testsuite/ChangeLog:
>>
>> PR breakpoints/22569
>> * gdb.linespec/ls-errs.exp: Change expected result of "break
>> -source this file has spaces.c -line 3".
>> Check that an explicit source file followed by whitespace is
>> identified as an invalid explicit location.
>
> This is quick customer support! This patch fixes the reported issue
> and LGTM.
I'm just happy to see someone is using the explicit location feature, and as you can see from the patch, it was pretty trivial anyway.
Thank you for the quick review, this patch has been pushed, and I will close the bug.
Keith
prev parent reply other threads:[~2017-12-07 23:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 21:20 Keith Seitz
2017-12-07 21:34 ` Simon Marchi
2017-12-07 23:41 ` Keith Seitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfb3b435-ec5e-7264-960e-42a7302682ad@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox