From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112839 invoked by alias); 7 Dec 2017 23:41:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112828 invoked by uid 89); 7 Dec 2017 23:41:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=customer X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 07 Dec 2017 23:41:01 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8324C83F43 for ; Thu, 7 Dec 2017 23:41:00 +0000 (UTC) Received: from theo.uglyboxes.com (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5BC4F17972 for ; Thu, 7 Dec 2017 23:41:00 +0000 (UTC) Subject: Re: [PATCH] Validate explicit locations with early termination To: gdb-patches@sourceware.org References: <20171207212046.13452-1-keiths@redhat.com> <003824fa-c538-3f02-729f-8bf8192d51a5@ericsson.com> From: Keith Seitz Message-ID: Date: Thu, 07 Dec 2017 23:41:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <003824fa-c538-3f02-729f-8bf8192d51a5@ericsson.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00154.txt.bz2 On 12/07/2017 01:33 PM, Simon Marchi wrote: hese two commands should have elicited the same error message. >> >> gdb/ChangeLog: >> >> PR breakpoints/22569 >> * location.c (string_to_explicit_location): When terminating >> parsing early, break out of enclosing loop instead of returning. >> >> gdb/testsuite/ChangeLog: >> >> PR breakpoints/22569 >> * gdb.linespec/ls-errs.exp: Change expected result of "break >> -source this file has spaces.c -line 3". >> Check that an explicit source file followed by whitespace is >> identified as an invalid explicit location. > > This is quick customer support! This patch fixes the reported issue > and LGTM. I'm just happy to see someone is using the explicit location feature, and as you can see from the patch, it was pretty trivial anyway. Thank you for the quick review, this patch has been pushed, and I will close the bug. Keith