From: Simon Marchi <simark@simark.ca>
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: Use add_setshow_zuinteger_unlimited_cmd in remote.c
Date: Sat, 07 Jul 2018 02:01:00 -0000 [thread overview]
Message-ID: <df6d7d75-c460-af0e-d1b0-e0e4c7b4c363@simark.ca> (raw)
In-Reply-To: <20180702221146.20201-1-andrew.burgess@embecosm.com>
On 2018-07-02 06:11 PM, Andrew Burgess wrote:
> @@ -1728,6 +1728,36 @@ show_memory_write_packet_size (const char *args, int from_tty)
> show_memory_packet_size (&memory_write_packet_config);
> }
>
> +/* Show the number of hardware watchpoints that can be used. */
> +
> +static void
> +show_hardware_watchpoint_limit (struct ui_file *file, int from_tty,
> + struct cmd_list_element *c, const char *value)
> +{
> + fprintf_filtered (file, _("The maximum number of target hardware "
> + "watchpoints is %s.\n"), value);
> +}
> +
> +/* Show the length limit (in bytes) for hardware watchpoints. */
> +
> +static void
> +show_hardware_watchpoint_length_limit (struct ui_file *file, int from_tty,
> + struct cmd_list_element *c, const char *value)
This line is too long. Otherwise, LGTM. Thanks!
Simon
next prev parent reply other threads:[~2018-07-07 2:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 22:11 Andrew Burgess
2018-07-04 16:46 ` Eli Zaretskii
2018-07-07 2:01 ` Simon Marchi [this message]
2018-07-09 15:11 ` Pedro Alves
2018-07-09 17:10 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df6d7d75-c460-af0e-d1b0-e0e4c7b4c363@simark.ca \
--to=simark@simark.ca \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox