Re: [PATCH] gdb: Use add_setshow_zuinteger_unlimited_cmd in remote.c

[Pedro Alves <palves@redhat.com>]

Hi Andrew,

Noticed a typo below.

On 07/02/2018 11:11 PM, Andrew Burgess wrote:

> @@ -21161,16 +21161,24 @@
>  @anchor{set remote hardware-breakpoint-limit}
>  @item set remote hardware-watchpoint-limit @var{limit}
>  @itemx set remote hardware-breakpoint-limit @var{limit}
> -Restrict @value{GDBN} to using @var{limit} remote hardware breakpoint or
> -watchpoints.  A limit of -1, the default, is treated as unlimited.
> +Restrict @value{GDBN} to using @var{limit} remote hardware watchpoints
> +or breakpoints.  The @var{limit} can be set to 0 to disable hardware
> +watchpoints or breakpoints, and @code{unilmited} for unlimited
> +watchpoints or breakpoints.

Typo:

 "unilmited" -> unlimited

>  Set the maximum length (in bytes) of a target hardware watchpoint."), _("\
>  Show the maximum length (in bytes) of a target hardware watchpoint."), _("\
> -Specify a negative limit for unlimited."),
> -			    NULL, NULL, /* FIXME: i18n: The maximum
> -                                           length (in bytes) of a target
> -                                           hardware watchpoint is %s.  */
> +Specify \"unlimited\" to allow unlimited sized watchpoints."),

While at it, a nit, shouldn't "unlimited sized" be hyphenated,
being a compound adjective:

 unlimited-sized watchpoints.

(in contrast with allowing an unlimited number of
"sized watchpoints", whatever that would be.)

Maybe this would be clearest:

 Specify \"unlimited\" to allow watchpoints of unlimited size."

Thanks,
Pedro Alves