From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Don't let TUI focus on locator
Date: Wed, 23 Sep 2020 15:57:18 -0400 [thread overview]
Message-ID: <df06b9b8-5d45-2e30-0559-73db7c49aa1f@simark.ca> (raw)
In-Reply-To: <877dskp917.fsf@tromey.com>
On 2020-09-23 3:50 p.m., Tom Tromey wrote:
> Simon> Instead of hard-coding here which windows can receive focus, how about
> Simon> having a tui_win_info virtual method "is_focusable", where the default
> Simon> implementation returns true, and tui_locator_window's implementation
> Simon> returns false? The code in tui_next_win / tui_prev_win would return the
> Simon> next / prev focusable window.
>
> Let me know what you think of this.
That looks good to me, thanks!
I've never looked at the TUI tests but... how hard would it be to write
a test for this?
Simon
next prev parent reply other threads:[~2020-09-23 19:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 18:59 Tom Tromey
2020-09-23 19:10 ` Simon Marchi
2020-09-23 19:50 ` Tom Tromey
2020-09-23 19:57 ` Simon Marchi [this message]
2020-09-24 18:27 ` Tom Tromey
2020-09-24 18:33 ` Simon Marchi
2020-09-24 19:02 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df06b9b8-5d45-2e30-0559-73db7c49aa1f@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox