From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id B3dcLaKoa1/SZQAAWB0awg (envelope-from ) for ; Wed, 23 Sep 2020 15:57:22 -0400 Received: by simark.ca (Postfix, from userid 112) id AAE801EE05; Wed, 23 Sep 2020 15:57:22 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 26CA91E509 for ; Wed, 23 Sep 2020 15:57:22 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 94587385702E; Wed, 23 Sep 2020 19:57:21 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 70B463857C7A for ; Wed, 23 Sep 2020 19:57:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 70B463857C7A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 0DC6C1E509; Wed, 23 Sep 2020 15:57:18 -0400 (EDT) Subject: Re: [PATCH] Don't let TUI focus on locator To: Tom Tromey References: <20200923185921.1006372-1-tromey@adacore.com> <1b3329ea-97c0-c379-d343-e891a337244b@simark.ca> <877dskp917.fsf@tromey.com> From: Simon Marchi Message-ID: Date: Wed, 23 Sep 2020 15:57:18 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <877dskp917.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2020-09-23 3:50 p.m., Tom Tromey wrote: > Simon> Instead of hard-coding here which windows can receive focus, how about > Simon> having a tui_win_info virtual method "is_focusable", where the default > Simon> implementation returns true, and tui_locator_window's implementation > Simon> returns false? The code in tui_next_win / tui_prev_win would return the > Simon> next / prev focusable window. > > Let me know what you think of this. That looks good to me, thanks! I've never looked at the TUI tests but... how hard would it be to write a test for this? Simon