From: Nick Clifton <nickc@redhat.com>
To: Jim Wilson <jim.wilson@linaro.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH] aarch64 sim xtn2 bug fix
Date: Mon, 16 Jan 2017 11:09:00 -0000 [thread overview]
Message-ID: <dee489bd-631b-971c-aa3e-2394bddd4c5c@redhat.com> (raw)
In-Reply-To: <CABXYE2UEN10HXU8tYYWaDs5DtMXiBFSCm2pLeckBSo_5bu9tqw@mail.gmail.com>
Hi Jim,
> The code is applying a bias (shift) to inputs which is wrong. The
> index in case 2 should be i + 2 not i + 4. We can simplify the code a
> little and remove the if statement, reducing 7 lines to 3 in each of
> the 3 cases.
>
> The testcase works with the patch, and fails without. The patch
> reduces GCC C testsuite failures from 2174 to 2108 (-66).
Approved - please apply.
Cheers
Nick
prev parent reply other threads:[~2017-01-16 11:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-14 19:21 Jim Wilson
2017-01-16 11:09 ` Nick Clifton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dee489bd-631b-971c-aa3e-2394bddd4c5c@redhat.com \
--to=nickc@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jim.wilson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox