From: Simon Marchi <simon.marchi@efficios.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/4] gdb/python: collapse some nested ifs
Date: Mon, 14 Sep 2026 15:46:48 -0400 [thread overview]
Message-ID: <ded94486-f2d8-44fe-9549-d285017c8344@efficios.com> (raw)
In-Reply-To: <87bj9zwrqt.fsf@tromey.com>
On 9/14/26 3:35 PM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
>
> Simon> While reviewing another patch in gdb/python, I found that some nested
> Simon> "ifs" could be collapsed into one. I had Claude hunt for more cases
> Simon> like that throughout gdb/python, and this patch changes them.
>
> Simon> - if (ds_obj != NULL)
> Simon> + if (ds_obj != NULL && gdbpy_is_string (ds_obj.get ()))
>
> nullptr
I fixed that and all the other "NULL" in the lines that I touched (there
was a handful).
Simon
next prev parent reply other threads:[~2026-09-14 19:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 19:19 [PATCH 1/4] gdb/python: check for nullptr before calling evpy_add_attribute Simon Marchi
2026-09-14 19:19 ` [PATCH 2/4] gdb/python: collapse some nested ifs Simon Marchi
2026-09-14 19:35 ` Tom Tromey
2026-09-14 19:46 ` Simon Marchi [this message]
2026-09-14 19:19 ` [PATCH 3/4] gdb/python: rename evregpy_no_listeners_p to evregpy_has_listeners_p Simon Marchi
2026-09-14 19:38 ` Tom Tromey
2026-09-14 19:19 ` [PATCH 4/4] gdb/python: remove more useless casts Simon Marchi
2026-09-14 19:39 ` Tom Tromey
2026-09-14 19:47 ` Simon Marchi
2026-09-14 19:24 ` [PATCH 1/4] gdb/python: check for nullptr before calling evpy_add_attribute Tom Tromey
2026-09-14 19:43 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ded94486-f2d8-44fe-9549-d285017c8344@efficios.com \
--to=simon.marchi@efficios.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox