From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id W6L/IEZPqGpoxgwAWB0awg (envelope-from ) for ; Mon, 14 Sep 2026 15:47:18 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=uhjT8Ice; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 740621E06B; Mon, 14 Sep 2026 15:47:18 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0F84A1E051 for ; Mon, 14 Sep 2026 15:47:18 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C1B614BB24C9 for ; Mon, 14 Sep 2026 19:47:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C1B614BB24C9 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=uhjT8Ice Received: from YT5PR01CU002.outbound.protection.outlook.com (mail-canadacentralazon11021120.outbound.protection.outlook.com [40.107.192.120]) by sourceware.org (Postfix) with ESMTPS id BF58B4BA79A4 for ; Mon, 14 Sep 2026 19:46:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BF58B4BA79A4 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BF58B4BA79A4 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=40.107.192.120 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1789415213; cv=pass; b=hMNEsYqjFHgQ8culuOvBHcDXRXYGheGUZpKwzWvL0ZVSkiva5lUg/cCc8hRP5SW33mFNsdSfqi7hJ4iBJPJKgiMxWCx1jiMM21XEfs0kvr0LqwQQYo0G+/GrQEkp9oBpi+gBZUUgtBVcz80v936Pezz0+E4pgs0JJ0GTY/oYw4g= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1789415213; c=relaxed/simple; bh=euyZayYRjUWZ6GEfm7z0TNN934r8us3d0pOIGjl++54=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=IR1l3cog/0hGGocxlD0kjSRitM4z/u3jVT+M2+fCqHrqRwh5hi1SKQAVrgpdzfWq/RZBRwCtUmUslzyNmyuHKTccBAzbF5LBQe1pbHjV1LC1N1BFdANts//fuG8b44q7AM0CNPBR7BqcrfFDwHR+XV4df6Y8aGFne/DnXvF83HI= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=uhjT8Ice DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BF58B4BA79A4 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XAoO5b26cFxdSNMqkGKlogtM5EG09mZsajBm1wdXNYPNaCHINRq4c7s2rAEnh9j4YS0d6OQC3+ScjD0TVStiMkpznAHX4KfHW60EL7ZKpvCy50T52qy27FD6jcGNzTkOHNZd83PvTWWU6LbrAOoAuWmLWJ/RpfXJznoAY+o77I6MGTrm+qM8FIy0JJdjr4HWbbSk2kylwr3w1PSCJwORX3Vt3D2EDlWCC0ziC1qHxNUqaMYs5gDMlxWTqC/wc+qlemrjwCdARF8KUmyT/Lx8Dgg23wsSq8krH4Au2QUOeFjhtXHb8MI7SPx/m5oG1612gS5G23kO+Ku+Nu089dbNIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1+tWUwJ8Wd4eIFCmDmZsUtvRz4A09m29m2DWkNa8+iU=; b=yScIuYAu874D8uEGbJlLgmG4oO34CbufDUGTs1MBt8nay7ZtbscDBtQyWWy7yiHUirT6FckrKnQmJuE/pWoxHF5NTbIz9bUyhr+vlYMlq8SaBdcIriQ2fGYJekP3o32D3gU5q9t0XEwd2UC3NSrBwkoK5taqwmwWv1OiVsxDshLii5nCZ1xYc7fyUScKIZ5W3udSjAPM8rzUJSeTlIvTVQX51N5UWIIQV3wo6aedQFsXtIl+K7c1BKgQ3zJT5BQ2gCZxHuNVu9NjMF5YGijBnqU3SQnlGZCVzTGZKTQOf71a0Z5rwGJJhz3qaHxaE23zdi3jpqBKST+WJMaCBbpLrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1+tWUwJ8Wd4eIFCmDmZsUtvRz4A09m29m2DWkNa8+iU=; b=uhjT8Ice9vTIfHIKHv4OEo0AMoSZlknctDL0dsdEkq4eqxHlpO7W1fGSErJqX9mrZLdBeVrEwWWGBpXgzCkhPTuZzKCoG7MVhktK+s5Dono/Y8hCLpugzF1vi3CVcrmY8bLiFdmpn4aORRkLi5qyTCuVxhrCYohZtFjY1YrwEbsQL9hASd67Y6tkvxUmH/hQW0Z2LsSYqBb+MS7a2hEANthr+06BSb0g7yJ7MxgzluCs8FeXIky7s/jA1RVrqMy9G/QtvlOUufCXBH+av+cdU00MFxicawY4l2mYXw6tDVSIuHQZQemsgt85BhH68ttuaPOOhi/052iW6bHLDE+iYQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) by YT5PR01MB436185.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:1a1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.12; Mon, 14 Sep 2026 19:46:49 +0000 Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d]) by YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d%7]) with mapi id 15.21.0406.007; Mon, 14 Sep 2026 19:46:48 +0000 Message-ID: Date: Mon, 14 Sep 2026 15:46:48 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] gdb/python: collapse some nested ifs To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260914191908.557014-1-simon.marchi@efficios.com> <20260914191908.557014-2-simon.marchi@efficios.com> <87bj9zwrqt.fsf@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87bj9zwrqt.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR0101CA0222.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:67::33) To YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5418:EE_|YT5PR01MB436185:EE_ X-MS-Office365-Filtering-Correlation-Id: 1365ee48-ae14-467d-8e68-08df1298ea73 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|366016|23010399003|10067099003|4143699003|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: 6RsbZonou/8gDcck0TSR0myNel+nMPhDPpATuXHpyBMeO9aKBh2c1nj6il74rTQjZo493Ri3dIuizfEfi61x39A2iMRscE1JCm2R9+QpN8FACsdTEe1GDKErkRgujwBI/LXwxqQjaZVAqpJlSJujrk4brxW9pQgLCIXSWZapa42LYO1N5w91b6Hm1EUbq9h3oQP0wHiD70i8wrvBfXeI9F7xH2TrqSG67jvbsa3+nPQOS9/c0VY8gsOzLLUbfu/Ayu0lZ2wQjTzHoLo2Ae5FA0OgEDLjwQdU/PUDXtbCGBLhq4Uf4S9B8vdZSNiYNSJnzsoWmRKo8CNyBMbE0A9oO2e/PCw6QYT7WouLoVuDKNiVetSHkZ6y+zHOzal6jkwBPSpLUdioCUOOJDWj9MdNK97+a4el6CZxw4JiGhnWi+ChR4gTb4wAJMFNntUj+AumHRoFLs9GCiZOkcPi1UwL54X+LI+JC9NyrgFV1zk6u6isIGYPdb/6mIOajPfq5vbsTnSBdB3uGSkWOqGNHx6zO25ULmdOaKSsM6c1xGNYOFmROLbZWz/LnBGg0cZ0yBAwGxECHPZnlLBylMZ1ZRKOCuBc7XkIc+6YcUv0fcBHDwhSWXNWYld1UvVGvPuQqzA+XYfq7kYTx1v7mn7VQPBkL5HIHnu4wqZSw4EwiVeUrsw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(23010399003)(10067099003)(4143699003)(56012099006)(18002099003)(22082099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ri93MWhId2VncHNiSU94d1hkR3VENHZpc0F5WVRrbEdFNzJyUVhxcHZhNEVp?= =?utf-8?B?MGU2aWQvUnJKaXBKdUQ3WTRJMjJheWt3bktybHNnYmJsRmd0VGhrZTdxdXM5?= =?utf-8?B?Z2prRE1SMFpiOVVMSXBQQnZwcm9UZm5pUGpFL2NmSWxKNnBzSzVFT1dxMXMy?= =?utf-8?B?Yy8xLzMzVW14cXRZMHdHRXdXM0gycm94VlFvL0pPMktTbkVzUUJWcisvaGk1?= =?utf-8?B?UXdFQ2Rpa3dtUUZWTldOWndVK1FHVzZYVUlkcnAvK3F3SmdBTXZ2Ykw3aW80?= =?utf-8?B?SzdiTHFZUFE2UENHY2F3aGFWQTVUNDNneitzRjY3cW9tcHZSbFVkbVVFZTJJ?= =?utf-8?B?dDF6WU5TUkRLSStHSE1vaDNaMWNxWlVkSU5MNGhXeXRFc3hGYjJleWtCNUdw?= =?utf-8?B?VkNmUkMxRjlDRE4rckhNeDd6SVpKczJRU1ZKWkhBUEQ1eCtWMGJ0aXFkUmw2?= =?utf-8?B?eDNFR1NFNWhEQmdRQXpGVVpqK0E3YUdNd28zYWVCbVYydXdudWhnbTBDaFFR?= =?utf-8?B?SnYrT05VNUdBL1BPMmF4QXorelIvakIwd0hrSGJOV2J4clI1MW96NGg0Q2pr?= =?utf-8?B?UU95Tm1yYkxiWkptRldIeGw4MXdrRkY5dEUwdHowYmREcU9PS1VlK0lTSWxG?= =?utf-8?B?aVBDd0Z1ZFdBTHVvZ3VCZVU4elNvL1NZbFJCWFlGOTRTS04vdU5KZHFmNms5?= =?utf-8?B?T2d6QlBjYThXV1ZSU2ZMMGRQclMxR2xyaWp5NWU3QXl4MW50d21rU1MzZC8y?= =?utf-8?B?WjdJbURPK0tmcEhqaGdqenhxQVhUZ3FiU3M4aHU1OVBEMUFzSk9SNEg0UEdR?= =?utf-8?B?S0RuLzBYUkN1ZVNwK3FIblB5UjFKc3FUSWFOY0pzN2VCS3dWZFAxR2V2ZUZP?= =?utf-8?B?ZG9sZlZOSnRlV2NsaWs1MmxMZW9ydmRFQTlPWmlBU3haM1dYZUFwYUV4S0RU?= =?utf-8?B?ZnA5RkdISnBQc2NGa080Z2lOd244QzFWRENrT201TzVnanhLUXF6MFdHMTlP?= =?utf-8?B?ZDlacVlKNmNnaXoveThJMXpnWHJGa2xDY1l0R2ZrNEJWZW96SG85SVU5OG0w?= =?utf-8?B?TU5PckFadE90eTRxb0I2RVpwZHNWWUZ0UGdNejhaNE9TUmpRVVJmWUNWRzI3?= =?utf-8?B?ck5ITm9BRnZ6M3pMWXdRN005S3RsTDUycThRZ3JJN1FUaG94ZzlvNys4aEJr?= =?utf-8?B?dkNKcjVEQWxhb0o5LzhPaDNjZTZHVUlqU0JPeGY5ZkR2dDJMdmEyMVpxRzJO?= =?utf-8?B?NSs0NGhzVzB5UUI2NnljUnJSRFFET1MrMnRBL3kwMzZsenBTcVg5dkJJQ2dG?= =?utf-8?B?S1pHMUhIaXZBMEFDOEJ3SlZDSHhoMS9LOFBuSkxIRlJ2ZGNNWEh4MS9RNVlF?= =?utf-8?B?UDZFUUdDTGlDMnA0bnA0ZHNadytrRnk4K2JxMC9OUzF5UUZ5NXptQ0ZFSFFH?= =?utf-8?B?ZVpEVVBGdkovbjErR3JPL1pJMFdpQW9vUG1ROVJuZjJrWEN4dlJBTkxDVlFB?= =?utf-8?B?U2N3aHd0Rm5sb0U0L0F5Z1gvSG9OSnpUcFAva21ORU9XMnprSkFLSVZ4djh6?= =?utf-8?B?dlNHRWRrNisyc3FJUWlPdG05bjgxN3R1YTN4dUJ6N0EwdW1hUVQxa2wzY0dq?= =?utf-8?B?dWZlU1ZtL2Erd0xQK2Q0ei9OWVkvUGwvbHNhOFUzVk15MWdtczBTcVk3dlpt?= =?utf-8?B?TTBPeUY5eUNOOVZvajE3eWhQOTI5OWxxVUtuUUN2RGo2OHBaY3RraUNWNjMx?= =?utf-8?B?OGVWNGxYd0Y0ckpJUi9pRlFuSWxLWkRIQ1VSMTROZ0lLMFdKdkd0UGpUYXRH?= =?utf-8?B?bzJQQm9NN0JRV2ptTHlPMW5SSU8rN2dkdHU1cTd5MEdvZlBwZWRWREh0Snda?= =?utf-8?B?K251NzZMVmthU2hjZTR1NXdqY29GTnp3US9kOTZQcERrSXhrSmFjdXBaaEJF?= =?utf-8?B?MG9UT1RHMlRIcGYxMFgydVVEQm5id1lIYWNVMFFyNzAxNzI1M0JlYnZyWWYz?= =?utf-8?B?ZXBxNktWVE0waHphMWdPL0pzQ0FQSzdBTVBaOEdVUmVFbWJ5NmRGWGNmT0F0?= =?utf-8?B?U0w3SlVVQldMb2tteUFZTjN5TFNpeThuS2RmN1YwcFNVdEN6ZS90bFlyVmI4?= =?utf-8?B?allWRHY2RGNhYmtDWDZiWStPUTVzWVB0b1JmU2l0S09hUGlDekI4ZzJLVEs2?= =?utf-8?B?cWpSRlV6NTZBWEM5YkZHZ1M5NnViaW5uWWo4QWFlVitLc0ZHQlBUVVpObDBh?= =?utf-8?B?TEZwZzlOQ3lNM1NXdXVNUHhqNC9ibXVjczUrT2J6NU00Nyt5Y20yemtlaU5T?= =?utf-8?B?MTRIRmc5azdYdGd1S052TVk5UmRiUHUzMm44Z0hwUUtnbGJ5eXpqdz09?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1365ee48-ae14-467d-8e68-08df1298ea73 X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2026 19:46:48.9172 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Mg8mx0iVaki5wUnNnaX6caOpLuqgJTeXZWkOlG9I+/We3BupuwWNXeUDxC2PBvahzBF/hs48PFc4dWMWY00xGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT5PR01MB436185 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/14/26 3:35 PM, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> While reviewing another patch in gdb/python, I found that some nested > Simon> "ifs" could be collapsed into one. I had Claude hunt for more cases > Simon> like that throughout gdb/python, and this patch changes them. > > Simon> - if (ds_obj != NULL) > Simon> + if (ds_obj != NULL && gdbpy_is_string (ds_obj.get ())) > > nullptr I fixed that and all the other "NULL" in the lines that I touched (there was a handful). Simon