From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Rename gdbpy_new_list
Date: Mon, 14 Sep 2026 09:26:55 -0400 [thread overview]
Message-ID: <de20e57e-25f6-433b-8e2d-7bb277dfa998@simark.ca> (raw)
In-Reply-To: <20260912143144.3724419-1-tom@tromey.com>
On 9/12/26 10:31 AM, Tom Tromey wrote:
> gdbpy_new_list did not follow the naming convention documented at the
> top of py-wrappers.h. This patch corrects the error.
Looks obvious to me.
Approved-By: Simon Marchi <simon.marchi@efficios.com>
In case you want to fix more, Claude also spotted this one:
- gdbpy_new_dict, should be gdbpy_dict_new (it has no callers)
And minor, but could be fixed at the same time:
- the doc for gdbpy_unicode_from_format says PyUnicode_FromFormatV, but
the implementation calls PyUnicode_FromFormat, the comment could be
fixed
I think that can all go in a "py-wrappers.h cleanups" obvious patch.
Simon
prev parent reply other threads:[~2026-09-14 13:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-12 14:31 Tom Tromey
2026-09-14 13:26 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de20e57e-25f6-433b-8e2d-7bb277dfa998@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox