From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QFF2Ljn2p2ryGQwAWB0awg (envelope-from ) for ; Mon, 14 Sep 2026 09:27:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1789392441; bh=XpN3lMzcBRIWcwQntYC/xzG6Xs1NgyScvvsKHY2TLbs=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Koz5EDLRLzZK4Cn+5Nb7INboqr6lt726zjBdXygLCijhYgFf5mfL3OvO2wVXtxkyx 9MYjecXMwBh/+67sPHubbULTTro2L4gIn7IBc1aJkxAdsgPvdPUDGijs1NGt+ghPms DOcIYsWAFBGTj++t4nktDhRqAUMnyIyxYFmZ4NWk= Received: by simark.ca (Postfix, from userid 112) id ACF621E066; Mon, 14 Sep 2026 09:27:21 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=SbByTGGy; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 324F01E01F for ; Mon, 14 Sep 2026 09:27:21 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1A4244BB1C39 for ; Mon, 14 Sep 2026 13:27:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1A4244BB1C39 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=SbByTGGy Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 2D5CA4BAE7DB for ; Mon, 14 Sep 2026 13:26:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2D5CA4BAE7DB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2D5CA4BAE7DB Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789392417; cv=none; b=e9g4OLoK2zQsuAidMxw3gW1hpkpUrQoErZUByGS6AGYrEaKP1ptIatwpUyVSfZpPbyrHXWGheWO9tB9eKRLZNfKPRFWO46prtK4D0zZP60GdNLjGnXPT4v7T4e9KBjlRRf088Fi5bWFaoo2F1QdbqPMbZ7mVSlp2NL2JDE/uBJU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789392417; c=relaxed/simple; bh=XpN3lMzcBRIWcwQntYC/xzG6Xs1NgyScvvsKHY2TLbs=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=tutLIdOZA+Wm+wumBDYMmDV2THXjKnABDX0YX+9GPoIicBav2yjdHtOG1/ZGxxFz2vDpgCGkK3I26qIqeEtggQgxuk59v6hl2GxKbLMsHLJnuhIuS1RHlM3i1rZXrksbE08cIyp4jRhK/rJRzUrZO7rDI2bnmqkQwphNBiSuYRE= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=SbByTGGy DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2D5CA4BAE7DB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1789392416; bh=XpN3lMzcBRIWcwQntYC/xzG6Xs1NgyScvvsKHY2TLbs=; h=Date:Subject:To:References:From:In-Reply-To:From; b=SbByTGGyoStqU/qSNvjYV0yh70BicShSoFBLHQ4jO3gMpdmzFOaPqJoeA4GUamehe FjJzC6WxJshfMMbsocc8X8AK4356wbiXh6sw7SYi6AdN2sicJXdvP00kqjDmmGTSLx NZnLVnCMS+0ZCz0VCCeZxfmN9Vaui3DKNHy8w6Cs= Received: by simark.ca (Postfix) id 397071E01F; Mon, 14 Sep 2026 09:26:56 -0400 (EDT) Message-ID: Date: Mon, 14 Sep 2026 09:26:55 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Rename gdbpy_new_list To: Tom Tromey , gdb-patches@sourceware.org References: <20260912143144.3724419-1-tom@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <20260912143144.3724419-1-tom@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/12/26 10:31 AM, Tom Tromey wrote: > gdbpy_new_list did not follow the naming convention documented at the > top of py-wrappers.h. This patch corrects the error. Looks obvious to me. Approved-By: Simon Marchi In case you want to fix more, Claude also spotted this one: - gdbpy_new_dict, should be gdbpy_dict_new (it has no callers) And minor, but could be fixed at the same time: - the doc for gdbpy_unicode_from_format says PyUnicode_FromFormatV, but the implementation calls PyUnicode_FromFormat, the comment could be fixed I think that can all go in a "py-wrappers.h cleanups" obvious patch. Simon