Re: [PATCH] Replace the remaining uses of strerror with safe_strerror

[Pedro Alves <palves@redhat.com>]

On 11/26/19 7:59 PM, Christian Biesinger via gdb-patches wrote:

> index c37db579f7..724a1d24db 100644
> --- a/gdb/gdbsupport/safe-strerror.c
> +++ b/gdb/gdbsupport/safe-strerror.c
> @@ -27,11 +27,18 @@ safe_strerror (int errnum)
>  {
>    static thread_local char buf[1024];
>  
> +#ifdef IN_PROCESS_AGENT
> +  /* IPA does not use Gnulib, but only supports Linux, so we can safely
> +     call the GNU version of strerror_r here.  It is documented not to
> +     return NULL.  */
> +  return strerror_r (errnum, buf, sizeof (buf));

GDBserver and (I assume) the IPA can be built with other C runtimes on Linux,
like musl and others.  Do you know how musl behaves?

Thanks,
Pedro Alves