From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93728 invoked by alias); 6 Dec 2019 20:06:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93707 invoked by uid 89); 6 Dec 2019 20:06:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-1.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (207.211.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Dec 2019 20:06:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575662782; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G+5M9ORAcFjfYJcDG0mTbLZOorJx65/E1Tu8NsWuRy4=; b=WkoTxmba140Eh210Gdmetp0ro3sv/UPY8jkGmxqEJ+FzJYW5iKNj92zwOs+9DhvUU97ckg mPUIgNpsGPOyimpZDwTentHQJw8DccKJfQDhOsxUwhrZRTdX8IvLFtHghVuhQLfQx0cBEJ G3PGzTNX8yjPEH27uFmmc/9i0XrwpyU= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-139-FW8C9jQ5MBqxWFP_Fcsqfg-1; Fri, 06 Dec 2019 15:06:19 -0500 Received: by mail-wm1-f71.google.com with SMTP id j203so2021133wma.2 for ; Fri, 06 Dec 2019 12:06:19 -0800 (PST) Return-Path: Received: from [192.168.1.108] ([83.223.250.73]) by smtp.gmail.com with ESMTPSA id m3sm17241503wrs.53.2019.12.06.12.06.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Dec 2019 12:06:17 -0800 (PST) Subject: Re: [PATCH] Replace the remaining uses of strerror with safe_strerror To: Christian Biesinger , gdb-patches@sourceware.org References: <20191126195901.50696-1-cbiesinger@google.com> From: Pedro Alves Message-ID: Date: Fri, 06 Dec 2019 20:06:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20191126195901.50696-1-cbiesinger@google.com> X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-12/txt/msg00244.txt.bz2 On 11/26/19 7:59 PM, Christian Biesinger via gdb-patches wrote: > index c37db579f7..724a1d24db 100644 > --- a/gdb/gdbsupport/safe-strerror.c > +++ b/gdb/gdbsupport/safe-strerror.c > @@ -27,11 +27,18 @@ safe_strerror (int errnum) > { > static thread_local char buf[1024]; > > +#ifdef IN_PROCESS_AGENT > + /* IPA does not use Gnulib, but only supports Linux, so we can safely > + call the GNU version of strerror_r here. It is documented not to > + return NULL. */ > + return strerror_r (errnum, buf, sizeof (buf)); GDBserver and (I assume) the IPA can be built with other C runtimes on Linux, like musl and others. Do you know how musl behaves? Thanks, Pedro Alves