From: Guinevere Larsen <guinevere@redhat.com>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Simplify get_frame_unwind_table
Date: Fri, 17 Jan 2025 17:33:02 -0300 [thread overview]
Message-ID: <dbd61309-83b9-4156-a842-ffdb1586d1ec@redhat.com> (raw)
In-Reply-To: <f40087e7-9c57-4c90-aa18-3b7282f086a1@redhat.com>
On 1/17/25 4:14 PM, Guinevere Larsen wrote:
> On 1/17/25 4:04 PM, Tom Tromey wrote:
>> This simplifies get_frame_unwind_table, changing it to use the
>> registry 'emplace' method and to pass the initialization iterators to
>> the constructor. This fixes a build problem on x86 -- reported by the
>> auto-builder -- as a side effect.
>
> I've tested this on buildbot and it fix the build. I encourage you to
> push it!
>
> Tested-By: Guinevere Larsen <guinevere@redhat.com>
>
Oh, seems like I replied this too early. Build fails on debian-armhf,
see log here:
https://builder.sourceware.org/buildbot/#/builders/72/builds/5614/steps/4/logs/stdio
--
Cheers,
Guinevere Larsen
She/Her/Hers
next prev parent reply other threads:[~2025-01-17 20:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 19:04 Tom Tromey
2025-01-17 19:14 ` Guinevere Larsen
2025-01-17 20:33 ` Guinevere Larsen [this message]
2025-01-17 21:27 ` Tom Tromey
2025-01-18 15:25 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbd61309-83b9-4156-a842-ffdb1586d1ec@redhat.com \
--to=guinevere@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox