From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id FHM9MKi+imcetRIAWB0awg (envelope-from ) for ; Fri, 17 Jan 2025 15:33:44 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=B5B6logN; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B5AF91E100; Fri, 17 Jan 2025 15:33:44 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EA5221E05C for ; Fri, 17 Jan 2025 15:33:43 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 91E2E383F41C for ; Fri, 17 Jan 2025 20:33:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 91E2E383F41C Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=B5B6logN Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 28D19383F5F6 for ; Fri, 17 Jan 2025 20:33:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 28D19383F5F6 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 28D19383F5F6 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737145989; cv=none; b=RQQsAe0d6vHfjEIgfeqjU4lB04WJowrf9uPsmI40fyNU63pQbCZh0YITm9koDwtYnJS1ZMEN37BdCF7AZjp39q0uMDtnNM0Dwn0zjt9CUl6z6/ncwgQ7TpD0/TZuaYX/qUYpFpxKGVABs/AnQLLILbjwr3T+d/qiTfAMjtHXYs8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737145989; c=relaxed/simple; bh=Z/dtIt0sXYyq7Lg0ZZ5dcbCs6sPJBA7QGwu2tRs20aY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=fO6Nc4ialbY24KPoZeGp2vX3rUSaWq0DW1qVvVWb26KKyvVZpZmLkoiS8pf/CXoNY9iisckyo+wFvvsLR3Bm8iBEimU8U3hnJwo9vDxLOMUkAyCubcOR6IlO/bpEtPXqYETvEn0/FEMs+AQGPMk0y/D9BwiOsNCbdW3Kh2vq7oI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 28D19383F5F6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737145988; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r2Q4GWOg5Dc8mjNbjFYmX5NnAqfyCDzM/nUg1PpU/K0=; b=B5B6logNu3BmCtAiWjZuHfiRQ0UtSelmmRs2L5nCMs6sYG255/v1tEu8HucnrvcbvIVWwD Xl8zrIBWWz8S0bENqC1Xx0wTbeG44NK7gWunK1anKqj3lRtrb6BwdyMZV3bSy4bdEQEMPu 4V0Y63pF/8TtCL8VApWClBo1slV4ug8= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-259-l7L-_Kp3OJ-hUggB0Vbvqg-1; Fri, 17 Jan 2025 15:33:07 -0500 X-MC-Unique: l7L-_Kp3OJ-hUggB0Vbvqg-1 X-Mimecast-MFC-AGG-ID: l7L-_Kp3OJ-hUggB0Vbvqg Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-2ee46799961so7199454a91.2 for ; Fri, 17 Jan 2025 12:33:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737145986; x=1737750786; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=r2Q4GWOg5Dc8mjNbjFYmX5NnAqfyCDzM/nUg1PpU/K0=; b=JGq/AWBwn3JGYJwntgo1aEZ0k3xoa4kSry7fTwVmatphcQsStLXPypDEnUvxAJQzoL bxQ8JG2V8q8YvhvPnnnrFgqFjrJvezyugcuAD19dApnA7bfM8NSwtC5gXvVOOzVVw6up +y3AuZyMab4nVEvHd67vlrhezV/rwxngaxQME3rR9QQMi0vTbPjFAS7qP8y+Ym+GwUja agpr4B7gazg4USigN6S8rhAPpHsO4dWFZ/iHSMr3qBky6B/w9ObqjFmrteO7QUQ+Sxn4 EAuMLay/EHC0MWm1nR0HR8/fLY9syW2DokVASu9IHkJbmR4m2apBGCaoJuKSLp6O7DuX gHew== X-Forwarded-Encrypted: i=1; AJvYcCXNMFSzyGusV+4ozeVRsPI0kVawMgS1JTBlfHMsUhcJgBxEBywvBD/lExQ6pQTWdTKPXwq9VLYLJuU/Jw==@sourceware.org X-Gm-Message-State: AOJu0YxHc35C3TAPpWe+IXOueW5dPWN0RKdJDUWRVIPqJodjmxeHOThV qrX2ZQWx4b5kj0a1VlliWiaSH3z/zcampGMSA5aLK/cxYmhyErJ5BwcXFHZxqZzV9VRPWV7wRHi EAoA1+OIE+FSt/nmCeVK/PTGSBXrpHba0BZEdNsUpPyH0TWauD5ntSKz3sagkHQBoGGo= X-Gm-Gg: ASbGnctMCj545YIbOf5nSPIY42PwapUevxulwjS3UnFQ5KJ78u/sVI4SJX1M+Q2YGs1 /3gbKQSHrwCUfeuYNsR+nIiQsHmMmEnyvYC6G9eesRb1YIX/5NgytvAIbVLyY1r/kkmiQHIJY1T CbWRzzmdPK9n4lx/7Y0XnS2jMzwLp855qfLigtlE5IcwoQfE9NcXhFD5K8hSO/+aKVllvwHeMw5 iYb8B7CNLXvyw6rR0O8dtUWJK5Qy7RBH6CfBEEttgNIxTx6g9y4JEU/RQtG77F9ka8c X-Received: by 2002:a05:6a00:b96:b0:72a:bc6a:3a85 with SMTP id d2e1a72fcca58-72dafbb6205mr5903562b3a.22.1737145986165; Fri, 17 Jan 2025 12:33:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IEw/b1pPELZagGeMM5q2Er/XbQw3lC3sIIQESJKK26o8lm7EX5aIgal99ZVyY9ttmLslijWiw== X-Received: by 2002:a05:6a00:b96:b0:72a:bc6a:3a85 with SMTP id d2e1a72fcca58-72dafbb6205mr5903540b3a.22.1737145985848; Fri, 17 Jan 2025 12:33:05 -0800 (PST) Received: from ?IPV6:2804:14d:8084:9a69::1001? ([2804:14d:8084:9a69::1001]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72dab813295sm2343753b3a.46.2025.01.17.12.33.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jan 2025 12:33:05 -0800 (PST) Message-ID: Date: Fri, 17 Jan 2025 17:33:02 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Simplify get_frame_unwind_table From: Guinevere Larsen To: Tom Tromey , gdb-patches@sourceware.org References: <20250117190453.1405884-1-tromey@adacore.com> In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ud215-MqaqCn4pVXZNpYju7j-cb387gzry4ZWNILYjc_1737145986 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 1/17/25 4:14 PM, Guinevere Larsen wrote: > On 1/17/25 4:04 PM, Tom Tromey wrote: >> This simplifies get_frame_unwind_table, changing it to use the >> registry 'emplace' method and to pass the initialization iterators to >> the constructor.  This fixes a build problem on x86 -- reported by the >> auto-builder -- as a side effect. > > I've tested this on buildbot and it fix the build. I encourage you to > push it! > > Tested-By: Guinevere Larsen > Oh, seems like I replied this too early. Build fails on debian-armhf, see log here: https://builder.sourceware.org/buildbot/#/builders/72/builds/5614/steps/4/logs/stdio -- Cheers, Guinevere Larsen She/Her/Hers