Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>,
	gdb-patches@sourceware.org
Subject: Re: [RFA] Removes a bunch of usages of gdb_suppress_tests in 'runto_main'
Date: Fri, 26 Oct 2018 10:51:00 -0000	[thread overview]
Message-ID: <db594151-9899-c05a-e840-08c9c8ad496c@redhat.com> (raw)
In-Reply-To: <20181025205832.15248-1-philippe.waroquiers@skynet.be>

Wow, thanks!

"removes" -> "remove" in subject.

On 10/25/2018 09:58 PM, Philippe Waroquiers wrote:
> In the 'info -q -t' patch series, I started a new test from
> gdb.threads/threadapply.exp, that uses an obsolete way to do
> runto_main.
> 
> This patch changes all occurences of runto_main using gdb_suppress_tests

occurences -> occurrences

> to use instead fail+return.
> 
> Note that there are still about 220 occurences of gdb_suppress_tests

Ditto.

> but unclear (to me) if these can be similarly trivially be replaced by a
> fail+return.  Further cleanup can be done in follow-up patches.

Certainly!

> 
> Tests run on Debian/x86_64.
> 
> gdb/testsuite/ChangeLog
> 2018-10-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
> 
> 	* gdb.arch/altivec-regs.exp: Do not use gdb_suppress_tests in
> 	runto_main, use fail + return instead.
> 	gdb.arch/amd64-byte.exp: Likewise.
> 	gdb.arch/amd64-dword.exp: Likewise.
> 	gdb.arch/amd64-word.exp: Likewise.
> 	gdb.arch/e500-abi.exp: Likewise.
> 	gdb.arch/e500-regs.exp: Likewise.
> 	gdb.arch/gdb1291.exp: Likewise.
> 	gdb.arch/gdb1431.exp: Likewise.
> 	gdb.arch/i386-avx.exp: Likewise.
> 	gdb.arch/i386-byte.exp: Likewise.
> 	gdb.arch/i386-prologue.exp: Likewise.
> 	gdb.arch/i386-sse.exp: Likewise.
> 	gdb.arch/i386-word.exp: Likewise.
> 	gdb.arch/iwmmxt-regs.exp: Likewise.
> 	gdb.arch/pa-nullify.exp: Likewise.
> 	gdb.arch/powerpc-prologue.exp: Likewise.
> 	gdb.arch/s390-tdbregs.exp: Likewise.
> 	gdb.arch/vsx-regs.exp: Likewise.
> 	gdb.asm/asm-source.exp: Likewise.
> 	gdb.base/auxv.exp: Likewise.
> 	gdb.base/bigcore.exp: Likewise.
> 	gdb.base/overlays.exp: Likewise.
> 	gdb.base/savedregs.exp: Likewise.
> 	gdb.base/setshow.exp: Likewise.
> 	gdb.base/sigaltstack.exp: Likewise.
> 	gdb.base/sigbpt.exp: Likewise.
> 	gdb.base/siginfo-addr.exp: Likewise.
> 	gdb.base/siginfo-obj.exp: Likewise.
> 	gdb.base/siginfo-thread.exp: Likewise.
> 	gdb.base/siginfo.exp: Likewise.
> 	gdb.base/signull.exp: Likewise.
> 	gdb.base/sigrepeat.exp: Likewise.
> 	gdb.base/structs2.exp: Likewise.
> 	gdb.threads/threadapply.exp: Likewise.
> 	gdb.threads/watchthreads.exp: Likewise.
> 	gdb.threads/watchthreads2.exp: Likewise.

OK.

Thanks,
Pedro Alves


      parent reply	other threads:[~2018-10-26 10:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-25 20:58 Philippe Waroquiers
2018-10-25 21:12 ` Philippe Waroquiers
2018-10-26 10:51 ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db594151-9899-c05a-e840-08c9c8ad496c@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=philippe.waroquiers@skynet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox